[QuickReview][Codemod][Lint:fbsource:RUSTFIX:clippy::io_other_error] Fix clippy::io_other_error issues in fbcode/antlir/antlir2/antlir2_vm/src

Reviewed By: dtolnay

Differential Revision: D89443569

fbshipit-source-id: 9b2c71b0a3254e7d54f04094f522d34d0dde91a7

Author: generatedunixname89002005320881

antlir/antlir2/antlir2_vm/src/utils.rs

@@ -38,23 +38,21 @@ pub(crate) fn log_command(command: &mut Command) -> &mut Command {
 /// finish fast.
 pub(crate) fn run_command_capture_output(command: &mut Command) -> Result<(), std::io::Error> {
     let output = log_command(command).output()?;
-    let stdout = String::from_utf8(output.stdout).map_err(|e| {
-        std::io::Error::new(ErrorKind::Other, format!("Failed to decode stdout: {e}"))
-    })?;
-    let stderr = String::from_utf8(output.stderr).map_err(|e| {
-        std::io::Error::new(ErrorKind::Other, format!("Failed to decode stderr: {e}"))
-    })?;
+    let stdout = String::from_utf8(output.stdout)
+        .map_err(|e| std::io::Error::other(format!("Failed to decode stdout: {e}")))?;
+    let stderr = String::from_utf8(output.stderr)
+        .map_err(|e| std::io::Error::other(format!("Failed to decode stderr: {e}")))?;
     if !output.status.success() {
         error!(
             "Command {} failed\nStdout: {}\nStderr: {}",
             command.get_program().to_string_lossy(),
             stdout,
             stderr
         );
-        return Err(std::io::Error::new(
-            ErrorKind::Other,
-            format!("Failed to execute command: {:?}", command),
-        ));
+        return Err(std::io::Error::other(format!(
+            "Failed to execute command: {:?}",
+            command
+        )));
     }
     if !stdout.is_empty() {
         debug!(stdout);

antlir/antlir2/antlir2_vm/src/vm.rs

@@ -351,19 +351,13 @@ impl<S: Share> VM<S> {
                     let msg = format!("Sidecar service at index {} finished unexpectedly", i);
                     error!("{}", &msg);
                     let status = x.join().map_err(|e| {
-                        VMError::SidecarError(std::io::Error::new(
-                            ErrorKind::Other,
-                            format!(
-                                "Failed to join thread for sidecar service at index {}: {:?}",
-                                i, e
-                            ),
-                        ))
+                        VMError::SidecarError(std::io::Error::other(format!(
+                            "Failed to join thread for sidecar service at index {}: {:?}",
+                            i, e
+                        )))
                     })?;
                     error!("Exit status {:#?}", status);
-                    return Err(VMError::SidecarError(std::io::Error::new(
-                        ErrorKind::Other,
-                        msg,
-                    )));
+                    return Err(VMError::SidecarError(std::io::Error::other(msg)));
                 }
                 Ok(())
             })