[antlir2][buck] create a wrapper for feature rules

Summary:
All feature rules must share certain attrs. Until this diff stack, that was
only the `plugin`, but now I want to add `location`, so I'm defining a macro
and converting all features to use it so that the rest of this stack is a bit
simpler.

Test Plan: waitforsandcastle

Reviewed By: naveedgol

Differential Revision: D87938675

fbshipit-source-id: b93a81f13276907a07923082c5a26146fd0f45fa

Author: vmagro

antlir/antlir2/features/clone/clone.bzl

@@ -5,7 +5,7 @@
 
 load("//antlir/antlir2/bzl:types.bzl", "LayerInfo")
 load("//antlir/antlir2/features:dependency_layer_info.bzl", "layer_dep", "layer_dep_analyze")
-load("//antlir/antlir2/features:feature_info.bzl", "FeatureAnalysis", "ParseTimeFeature")
+load("//antlir/antlir2/features:feature_info.bzl", "FeatureAnalysis", "ParseTimeFeature", "new_feature_rule")
 
 def clone(
         *,
@@ -151,13 +151,12 @@ def _impl(ctx: AnalysisContext) -> list[Provider]:
         ),
     ]
 
-clone_rule = rule(
+clone_rule = new_feature_rule(
     impl = _impl,
     attrs = {
         "dst_path": attrs.option(attrs.string(), default = None),
         "group": attrs.option(attrs.string(), default = None),
         "path": attrs.option(attrs.string(), default = None),
-        "plugin": attrs.label(),
         "src_layer": attrs.dep(providers = [LayerInfo]),
         "src_path": attrs.option(attrs.string(), default = None),
         "user": attrs.option(attrs.string(), default = None),

antlir/antlir2/features/dot_meta/dot_meta.bzl

@@ -4,7 +4,7 @@
 # LICENSE file in the root directory of this source tree.
 
 load("//antlir/antlir2/bzl:build_phase.bzl", "BuildPhase")
-load("//antlir/antlir2/features:feature_info.bzl", "FeatureAnalysis", "ParseTimeFeature")
+load("//antlir/antlir2/features:feature_info.bzl", "FeatureAnalysis", "ParseTimeFeature", "new_feature_rule")
 
 def dot_meta(
         *,
@@ -58,10 +58,9 @@ def _impl(ctx: AnalysisContext) -> list[Provider]:
         ),
     ]
 
-dot_meta_rule = rule(
+dot_meta_rule = new_feature_rule(
     impl = _impl,
     attrs = {
         "build_info": attrs.dict(attrs.string(), attrs.option(attrs.string())),
-        "plugin": attrs.label(),
     },
 )

antlir/antlir2/features/ensure_dir_exists/ensure_dir_exists.bzl

@@ -10,6 +10,7 @@ load(
     "FeatureAnalysis",
     "MultiFeatureAnalysis",
     "ParseTimeFeature",
+    "new_feature_rule",
 )
 load("//antlir/bzl:stat.bzl", "stat")
 
@@ -89,14 +90,13 @@ def _impl(ctx: AnalysisContext) -> list[Provider]:
         ),
     ]
 
-ensure_dir_exists_rule = rule(
+ensure_dir_exists_rule = new_feature_rule(
     impl = _impl,
     attrs = {
         "build_phase": attrs.enum(BuildPhase.values(), default = "compile"),
         "group": attrs.string(),
         "into_dir": attrs.string(),
         "mode": attrs.one_of(attrs.string(), attrs.int()),
-        "plugin": attrs.label(),
         "subdirs_to_create": attrs.string(),
         "user": attrs.string(),
     },

antlir/antlir2/features/extract/extract.bzl

@@ -26,7 +26,12 @@ load("//antlir/antlir2/bzl:debuginfo.bzl", "split_binary_anon")
 load("//antlir/antlir2/bzl:platform.bzl", "arch_select")
 load("//antlir/antlir2/bzl:types.bzl", "LayerInfo")
 load("//antlir/antlir2/features:dependency_layer_info.bzl", "layer_dep_analyze")
-load("//antlir/antlir2/features:feature_info.bzl", "FeatureAnalysis", "ParseTimeFeature")
+load(
+    "//antlir/antlir2/features:feature_info.bzl",
+    "FeatureAnalysis",
+    "ParseTimeFeature",
+    "new_feature_rule",
+)
 load("//antlir/buck2/bzl:ensure_single_output.bzl", "ensure_single_output")
 load("//antlir/bzl:internal_external.bzl", "internal_external")
 
@@ -127,12 +132,11 @@ def _extract_from_layer_impl(ctx: AnalysisContext) -> list[Provider]:
         ),
     ]
 
-extract_from_layer_rule = rule(
+extract_from_layer_rule = new_feature_rule(
     impl = _extract_from_layer_impl,
     attrs = {
         "binaries": attrs.list(attrs.string(), default = []),
         "layer": attrs.dep(providers = [LayerInfo]),
-        "plugin": attrs.label(),
     },
 )
 
@@ -182,11 +186,10 @@ def _extract_buck_binary_impl(ctx: AnalysisContext) -> list[Provider]:
         ),
     ]
 
-extract_buck_binary_rule = rule(
+extract_buck_binary_rule = new_feature_rule(
     impl = _extract_buck_binary_impl,
     attrs = {
         "dst": attrs.option(attrs.string(), default = None),
-        "plugin": attrs.label(),
         "src": attrs.dep(providers = [RunInfo]),
         "strip": attrs.bool(default = True),
         "target_arch": attrs.string(),

antlir/antlir2/features/feature_info.bzl

@@ -164,6 +164,17 @@ def data_only_feature_rule(
         attrs = feature_attrs | {"plugin": attrs.label()},
     )
 
+def new_feature_rule(
+        *,
+        impl,
+        attrs: dict[str, Attr]):
+    return rule(
+        impl = impl,
+        attrs = {
+            "plugin": native.attrs.label(),
+        } | attrs,
+    )
+
 def with_phase_override(
         feature: FeatureAnalysis,
         *,

antlir/antlir2/features/genrule/genrule.bzl

@@ -4,7 +4,7 @@
 # LICENSE file in the root directory of this source tree.
 
 load("//antlir/antlir2/bzl:build_phase.bzl", "BuildPhase")
-load("//antlir/antlir2/features:feature_info.bzl", "FeatureAnalysis", "ParseTimeFeature")
+load("//antlir/antlir2/features:feature_info.bzl", "FeatureAnalysis", "ParseTimeFeature", "new_feature_rule")
 
 def genrule(
         *,
@@ -58,14 +58,13 @@ def _genrule_impl(ctx: AnalysisContext) -> list[Provider]:
         plugin = ctx.attrs.plugin,
     )]
 
-genrule_rule = rule(
+genrule_rule = new_feature_rule(
     impl = _genrule_impl,
     attrs = {
         # TODO: just use attrs.arg() by itself
         "args": attrs.dict(attrs.string(), attrs.arg()),
         "bind_repo_ro": attrs.bool(),
         "mount_platform": attrs.bool(),
-        "plugin": attrs.label(),
         "user": attrs.string(),
     },
 )

antlir/antlir2/features/group/group.bzl

@@ -8,6 +8,7 @@ load(
     "//antlir/antlir2/features:feature_info.bzl",
     "FeatureAnalysis",
     "ParseTimeFeature",
+    "new_feature_rule",
 )
 load("//antlir/buck2/bzl:ensure_single_output.bzl", "ensure_single_output")
 
@@ -48,11 +49,10 @@ def _impl(ctx: AnalysisContext) -> list[Provider]:
         ),
     ]
 
-group_rule = rule(
+group_rule = new_feature_rule(
     impl = _impl,
     attrs = {
         "groupname": attrs.string(),
-        "plugin": attrs.label(),
         "uidmap": attrs.dep(),
     },
 )

antlir/antlir2/features/install/install.bzl

@@ -17,6 +17,7 @@ load(
     "FeatureAnalysis",
     "MultiFeatureAnalysis",
     "ParseTimeFeature",
+    "new_feature_rule",
 )
 load("//antlir/antlir2/features/rpm:rpm.bzl", "rpms_rule")
 load("//antlir/buck2/bzl:ensure_single_output.bzl", "ensure_single_output")
@@ -515,7 +516,7 @@ def _impl(ctx: AnalysisContext) -> list[Provider] | Promise:
 
     return anon_rpm_target.promise.map(_map)
 
-install_rule = rule(
+install_rule = new_feature_rule(
     impl = _impl,
     attrs = {
         "always_use_gnu_debuglink": attrs.bool(default = True),
@@ -535,7 +536,6 @@ install_rule = rule(
             default = False,
             doc = "Always install as a regular file, even in @mode/dev",
         ),
-        "plugin": attrs.label(),
         "setcap": attrs.option(attrs.string(), default = None),
         "split_debuginfo": attrs.bool(default = True),
         "src": attrs.option(

antlir/antlir2/features/mount/mount.bzl

@@ -4,7 +4,7 @@
 # LICENSE file in the root directory of this source tree.
 
 load("//antlir/antlir2/bzl:types.bzl", "LayerInfo")
-load("//antlir/antlir2/features:feature_info.bzl", "FeatureAnalysis", "ParseTimeFeature")
+load("//antlir/antlir2/features:feature_info.bzl", "FeatureAnalysis", "ParseTimeFeature", "new_feature_rule")
 load("//antlir/bzl:types.bzl", "types")
 
 # IMO this is a misfeature, but it is used in many places throughout the legacy
@@ -92,14 +92,13 @@ def _impl(ctx: AnalysisContext) -> list[Provider]:
     else:
         fail("invalid source_kind '{}'".format(ctx.attrs.source_kind))
 
-mount_rule = rule(
+mount_rule = new_feature_rule(
     impl = _impl,
     attrs = {
         "host_source": attrs.option(attrs.string()),
         "is_directory": attrs.option(attrs.bool()),
         "layer": attrs.option(attrs.dep(providers = [LayerInfo]), default = None),
         "mountpoint": attrs.option(attrs.string()),
-        "plugin": attrs.label(),
         "source_kind": attrs.enum(["layer", "host"]),
     },
 )

antlir/antlir2/features/rpm/rpm.bzl

@@ -15,6 +15,7 @@ load(
     "ParseTimeFeature",
     "Planner",
     "feature_record",
+    "new_feature_rule",
 )
 load("//antlir/buck2/bzl:ensure_single_output.bzl", "ensure_single_output")
 load("//antlir/bzl:structs.bzl", "structs")
@@ -288,7 +289,7 @@ def _impl(ctx: AnalysisContext) -> list[Provider]:
         ),
     ]
 
-rpms_rule = rule(
+rpms_rule = new_feature_rule(
     impl = _impl,
     attrs = {
         "action": attrs.enum(["install", "remove", "remove_if_exists", "upgrade", "module_enable"]),
@@ -300,7 +301,6 @@ rpms_rule = rule(
         # support
         "driver": attrs.dep(providers = [RunInfo]),
         "plan": attrs.exec_dep(providers = [RunInfo]),
-        "plugin": attrs.label(),
         "resolve": attrs.dep(providers = [RunInfo]),
         "subjects": attrs.list(attrs.string()),
         "subjects_src": attrs.option(attrs.source(), default = None),