Skip to content

Commit ce8c82c

Browse files
Adam Cantrowitzmeta-codesync[bot]
authored andcommitted
Migrate from special_tags to tpx_labels in fbcode (3/4)
Summary: Migrate from special_tags to tpx_labels across first half of fbcode (admarket through infra_asic_fpga). Updates 471 files covering ads, AI/ML, data infrastructure, build systems, and hardware test targets. Test Plan: Buck build verification will be performed by CI Reviewed By: yingufan Differential Revision: D89186614 fbshipit-source-id: 8f2923cf95a66677fbe91884be371b892ff198a8
1 parent 1b29474 commit ce8c82c

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

antlir/antlir2/antlir2_vm/bzl/test.bzl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
# LICENSE file in the root directory of this source tree.
55

66
# @oss-disable[end= ]: load("@fbcode_macros//build_defs:fully_qualified_test_name_rollout.bzl", "NAMING_ROLLOUT_LABEL", "fully_qualified_test_name_rollout")
7-
# @oss-disable[end= ]: load("@fbsource//tools/build_defs:testpilot_defs.bzl", "special_tags")
7+
# @oss-disable[end= ]: load("@fbsource//tools/build_defs:testpilot_defs.bzl", "tpx_labels")
88
# @oss-disable[end= ]: load("@fbsource//tools/target_determinator/macros:ci.bzl", "ci")
99
load("@prelude//utils:selects.bzl", "selects")
1010
load("//antlir/antlir2/bzl:platform.bzl", "arch_select", "rule_with_default_target_platform")
@@ -13,7 +13,7 @@ load("//antlir/buck2/bzl:ensure_single_output.bzl", "ensure_single_output")
1313
load("//antlir/bzl:build_defs.bzl", "add_test_framework_label", "buck_sh_test", "cpp_unittest", "python_unittest", "rust_unittest")
1414
# @oss-disable[end= ]: load(":disable_dev_mode.bzl", "disable_dev_mode")
1515

16-
load("//antlir/bzl:oss_shim.bzl", "NAMING_ROLLOUT_LABEL", "special_tags", "fully_qualified_test_name_rollout") # @oss-enable
16+
load("//antlir/bzl:oss_shim.bzl", "NAMING_ROLLOUT_LABEL", "tpx_labels", "fully_qualified_test_name_rollout") # @oss-enable
1717
load(":types.bzl", "VMHostInfo")
1818

1919
def _impl(ctx: AnalysisContext) -> list[Provider]:
@@ -192,10 +192,10 @@ def _get_internal_labels(test_rule, run_as_bundle: bool) -> (list[str], list[str
192192
"""
193193
wrapper_labels = ["heavyweight"]
194194
if run_as_bundle:
195-
wrapper_labels.append(special_tags.run_as_bundle)
195+
wrapper_labels.append(tpx_labels.run_as_bundle)
196196
if fully_qualified_test_name_rollout.use_fully_qualified_name():
197197
wrapper_labels = wrapper_labels + [NAMING_ROLLOUT_LABEL]
198-
wrapper_labels.append(special_tags.enable_artifact_reporting)
198+
wrapper_labels.append(tpx_labels.enable_artifact_reporting)
199199

200200
inner_labels = add_test_framework_label(HIDE_TEST_LABELS, "test-framework=8:vmtest")
201201

antlir/antlir2/testing/image_test.bzl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
# LICENSE file in the root directory of this source tree.
55

66
# @oss-disable[end= ]: load("@fbcode_macros//build_defs:fully_qualified_test_name_rollout.bzl", "NAMING_ROLLOUT_LABEL", "fully_qualified_test_name_rollout")
7-
# @oss-disable[end= ]: load("@fbsource//tools/build_defs:testpilot_defs.bzl", "special_tags")
7+
# @oss-disable[end= ]: load("@fbsource//tools/build_defs:testpilot_defs.bzl", "tpx_labels")
88
# @oss-disable[end= ]: load("@fbsource//tools/target_determinator/macros:ci.bzl", "ci")
99
load("@prelude//utils:selects.bzl", "selects")
1010
load("//antlir/antlir2/antlir2_rootless:cfg.bzl", "rootless_cfg")
@@ -16,11 +16,11 @@ load("//antlir/antlir2/bzl/feature:defs.bzl", "feature")
1616
load("//antlir/antlir2/bzl/image:cfg.bzl", "cfg_attrs", "layer_cfg")
1717
load("//antlir/antlir2/bzl/image:defs.bzl", "image")
1818
load("//antlir/bzl:build_defs.bzl", "add_test_framework_label", "buck_sh_test", "cpp_unittest", "python_unittest", "rust_unittest")
19-
load("//antlir/bzl:oss_shim.bzl", "special_tags") # @oss-enable
19+
load("//antlir/bzl:oss_shim.bzl", "tpx_labels") # @oss-enable
2020

2121
load("//antlir/bzl:internal_external.bzl", "internal_external", "is_facebook")
2222

23-
HIDE_TEST_LABELS = [special_tags.disabled, special_tags.test_is_invisible_to_testpilot]
23+
HIDE_TEST_LABELS = [tpx_labels.disabled, tpx_labels.test_is_invisible_to_testpilot]
2424

2525
def env_from_wrapped_test(wrapped_test):
2626
env = dict(wrapped_test[ExternalRunnerTestInfo].env)
@@ -308,7 +308,7 @@ def _implicit_image_test(
308308
layer = layer,
309309
run_as_user = run_as_user,
310310
test = ":" + name + "_image_test_inner",
311-
labels = labels + [special_tags.enable_artifact_reporting],
311+
labels = labels + [tpx_labels.enable_artifact_reporting],
312312
boot = boot,
313313
boot_requires_units = boot_requires_units,
314314
boot_after_units = boot_after_units,

antlir/antlir2/testing/test_that_should_fail.bzl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44
# LICENSE file in the root directory of this source tree.
55

66
# @oss-disable[end= ]: load("@fbcode_macros//build_defs:fully_qualified_test_name_rollout.bzl", "NAMING_ROLLOUT_LABEL", "fully_qualified_test_name_rollout")
7-
# @oss-disable[end= ]: load("@fbsource//tools/build_defs:testpilot_defs.bzl", "special_tags")
7+
# @oss-disable[end= ]: load("@fbsource//tools/build_defs:testpilot_defs.bzl", "tpx_labels")
88
load("//antlir/antlir2/bzl:platform.bzl", "default_target_platform_kwargs")
99
load("//antlir/bzl:build_defs.bzl", "buck_sh_test", "cpp_unittest", "python_unittest", "rust_unittest")
10-
load("//antlir/bzl:oss_shim.bzl", "special_tags") # @oss-enable
10+
load("//antlir/bzl:oss_shim.bzl", "tpx_labels") # @oss-enable
1111

12-
_HIDE_TEST_LABELS = [special_tags.disabled, special_tags.test_is_invisible_to_testpilot]
12+
_HIDE_TEST_LABELS = [tpx_labels.disabled, tpx_labels.test_is_invisible_to_testpilot]
1313

1414
def _impl(ctx: AnalysisContext) -> list[Provider]:
1515
test_cmd = cmd_args(

0 commit comments

Comments
 (0)