Commit ef95d6c
Passing NULL into a Vectorcall is bad -> SIGSEG: address not mapped to object
Summary:
User Report
https://fburl.com/scuba/coredumper/4xq4bh4i
{P1917512020}
_PyFunction_Vectorcall calls _PyEval_Vector and @ https://www.internalfb.com/code/fbsource/[c921a6a6cff8]/third-party/python/3.12/Python/ceval.c?lines=1678 calls Py_INCREF on every argument. You can not call that on a NULL so while I didn't see documentation that you can't pass NULLS to vectorcall this is clear code that "you can't pass NULLS to vectorcalls"
Replace this with Py_None which can be passed in.
Reviewed By: zolyfarkas-fb
Differential Revision: D81263333
fbshipit-source-id: 17d57e7309f31b092d9077e909e15b6edaac72fe1 parent ca64130 commit ef95d6c
2 files changed
+5
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1440 | 1440 | | |
1441 | 1441 | | |
1442 | 1442 | | |
| 1443 | + | |
| 1444 | + | |
| 1445 | + | |
1443 | 1446 | | |
1444 | 1447 | | |
1445 | 1448 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| |||
1120 | 1120 | | |
1121 | 1121 | | |
1122 | 1122 | | |
1123 | | - | |
| 1123 | + | |
1124 | 1124 | | |
1125 | 1125 | | |
1126 | 1126 | | |
| |||
0 commit comments