Move capture_compilation_times_for and s_use_stable_pointers into Config

Summary:
Move two process-lifetime configuration globals into the `jit::Config` struct:

- `capture_compilation_times_for` from `Jit/jit_time_log.cpp` — list of
  function name patterns for compilation time capture.
- `s_use_stable_pointers` from `Common/util.cpp` — testing flag for
  deterministic pointer output.

Both are configuration-like values with process lifetime that naturally
belong in Config rather than as file-scope globals.

Reviewed By: yoney

Differential Revision: D96480903

fbshipit-source-id: 1487afa84bde791a6a585161f175aaa261ee6ad5

Author: alexmalyshev

cinderx/Common/util.cpp

@@ -8,6 +8,7 @@
 
 #include "cinderx/Common/log.h"
 #include "cinderx/Common/ref.h"
+#include "cinderx/Jit/config.h"
 
 #include <cstdarg>
 #include <cstdio>
@@ -103,15 +104,14 @@ jit_string_t* ss_sprintf_alloc(const char* format, ...) {
 
 namespace jit {
 
-static bool s_use_stable_pointers{false};
-
 const void* getStablePointer(const void* ptr) {
-  return s_use_stable_pointers ? reinterpret_cast<const void*>(0xdeadbeef)
-                               : ptr;
+  return getConfig().use_stable_pointers
+      ? reinterpret_cast<const void*>(0xdeadbeef)
+      : ptr;
 }
 
 void setUseStablePointers(bool enable) {
-  s_use_stable_pointers = enable;
+  getMutableConfig().use_stable_pointers = enable;
 }
 
 std::string unicodeAsString(PyObject* str) {

cinderx/Jit/config.h

@@ -6,6 +6,7 @@
 #include <cstdint>
 #include <optional>
 #include <string>
+#include <vector>
 
 namespace jit {
 
@@ -203,6 +204,12 @@ struct Config {
 
   // The ASM syntax the JIT should use when disassembling.
   AsmSyntax asm_syntax{AsmSyntax::ATT};
+
+  // List of function name patterns for which to capture compilation times.
+  std::vector<std::string> capture_compilation_times_for;
+
+  // Use stable sentinel pointers in output (for deterministic test output).
+  bool use_stable_pointers{false};
 };
 
 // Get the JIT's current config object.

cinderx/Jit/jit_time_log.cpp

@@ -3,6 +3,7 @@
 #include "cinderx/Jit/jit_time_log.h"
 
 #include "cinderx/Common/log.h"
+#include "cinderx/Jit/config.h"
 #include "cinderx/Jit/containers.h"
 
 #include <fmt/core.h>
@@ -14,18 +15,17 @@
 
 namespace jit {
 
-static std::vector<std::string> capture_compilation_times_for;
-
 void parseAndSetFuncList(const std::string& flag_value) {
-  capture_compilation_times_for.clear();
+  auto& func_list = getMutableConfig().capture_compilation_times_for;
+  func_list.clear();
 
   std::stringstream ss(flag_value);
 
   while (ss.good()) {
     std::string substr;
     getline(ss, substr, ',');
     if (!substr.empty()) {
-      capture_compilation_times_for.emplace_back(substr);
+      func_list.emplace_back(substr);
     }
   }
 }
@@ -63,7 +63,7 @@ bool isMatch(const std::string& word, const std::string& pattern) {
 }
 
 bool captureCompilationTimeFor(const std::string& function_name) {
-  for (const std::string& pattern : capture_compilation_times_for) {
+  for (const std::string& pattern : getConfig().capture_compilation_times_for) {
     if (isMatch(function_name, pattern)) {
       return true;
     }

cinderx/Jit/pyjit.cpp

@@ -3513,13 +3513,15 @@ int initialize() {
     return 0;
   }
 
-  // Save the force_init field as it might have be set by test code before
-  // jit::initialize() is called.
+  // Save fields that might have been set by test code before jit::initialize()
+  // is called.
   auto force_init = getConfig().force_init;
+  auto use_stable_pointers = getConfig().use_stable_pointers;
   getMutableConfig() = Config{};
   if (force_init.has_value()) {
     getMutableConfig().force_init = force_init;
   }
+  getMutableConfig().use_stable_pointers = use_stable_pointers;
 
   FlagProcessor flag_processor = initFlagProcessor();
   if (flag_processor.hasHandled("jit-help")) {