Suppress pyre errors in test cases

DinoV · meta-codesync[bot] · commit f9c62036b243 · 2025-11-17T20:28:45.000-08:00
Summary: Various test cases have pyre errors that will show up if we make them buck targets. This just suppresses the errors or makes very minimal changes so that they are well typed.

Reviewed By: yoney

Differential Revision: D87259595

fbshipit-source-id: 77e936fbe466b7a629b709293db9e12d2790bc4c
diff --git a/cinderx/PythonLib/test_cinderx/multithreaded_compile_test.py b/cinderx/PythonLib/test_cinderx/multithreaded_compile_test.py
@@ -1,4 +1,5 @@
 # Copyright (c) Meta Platforms, Inc. and affiliates.
+# pyre-ignore-all-errors
 
 # This script exercises multi-threaded JIT compilation by importing a bunch of
 # things and then calling a magic function on the cinderjit module to do a
diff --git a/cinderx/PythonLib/test_cinderx/test___static__/test_enum.py b/cinderx/PythonLib/test_cinderx/test___static__/test_enum.py
@@ -91,4 +91,5 @@ def test_duplicates(self) -> None:
         )
 
     def test_iteration(self) -> None:
+        # pyre-ignore[6]: Incompatible parameter type
         self.assertEqual(set(Shape), {Shape.SQUARE, Shape.CIRCLE})
diff --git a/cinderx/PythonLib/test_cinderx/test___static__/test_native_utils.py b/cinderx/PythonLib/test_cinderx/test___static__/test_native_utils.py
@@ -31,8 +31,11 @@ def test_native_lookup(self) -> None:
         target = "libc.so.6"
         symbol = "labs"
 
+        # pyre-ignore[16]: unknown attribute
         handle = _ctypes.dlopen(target)
+        # pyre-ignore[16]: unknown attribute
         ctypes_result = _ctypes.dlsym(handle, symbol)
+        # pyre-ignore[16]: unknown attribute
         _ctypes.dlclose(handle)
 
         result = lookup_native_symbol(target, symbol)
diff --git a/cinderx/PythonLib/test_cinderx/test___static__/tests.py b/cinderx/PythonLib/test_cinderx/test___static__/tests.py
@@ -126,6 +126,7 @@ def test_cast_fail(self) -> None:
     def test_cast_optional(self) -> None:
         self.assertIs(cast(Optional[int], None), None)
         self.assertIs(cast(int | None, None), None)
+        # pyre-ignore[20]: missing arg to __ror__
         self.assertIs(cast(None | int, None), None)
 
     def test_cast_generic_type(self) -> None:
@@ -136,14 +137,17 @@ class G(Generic[T]):
 
         g = G()
 
+        # pyre-ignore[16]: no attribute __getitem__
         self.assertIs(cast(G[int], g), g)
 
     def test_cast_type_too_complex(self) -> None:
         with self.assertRaisesRegex(ValueError, r"cast expects type or Optional\[T\]"):
             cast(Union[int, str], int)
 
     def test_rand(self) -> None:
+        # pyre-ignore[16]: no attribute RAND_MAX
         self.assertEqual(type(RAND_MAX), int)
+        # pyre-ignore[16]: no attribute RAND_MAX
         self.assertLessEqual(rand(), RAND_MAX)
         self.assertGreaterEqual(rand(), 0)
 
diff --git a/cinderx/PythonLib/test_cinderx/test_asynclazyvalue.py b/cinderx/PythonLib/test_cinderx/test_asynclazyvalue.py
@@ -1,4 +1,5 @@
 # Copyright (c) Meta Platforms, Inc. and affiliates.
+# pyre-ignore-all-errors
 
 import asyncio
 import inspect
diff --git a/cinderx/PythonLib/test_cinderx/test_compiler/common.py b/cinderx/PythonLib/test_cinderx/test_compiler/common.py
@@ -29,6 +29,7 @@
 )
 
 if sys.version_info >= (3, 14):
+    # pyre-ignore[21]: unknown imports
     from dis import (
         _get_code_object,
         _make_labels_map,
@@ -85,6 +86,7 @@ def get_disassembly_as_string(self, co: Disassembleable) -> str:
             return s.getvalue()
 
         # pyre-ignore[10]: Formatter defined for 3.14+
+        # pyre-ignore[16]: dis has no Formatter
         formatter = Formatter(file=s, offset_width=3)
         # pyre-ignore[10]: Formatter defined for 3.14+
         bc = Bytecode(co)
@@ -109,6 +111,7 @@ def make_static_instr(
                 instr[1],
                 instr.arg,
                 # pyre-ignore[10]: Formatter defined for 3.14+
+                # pyre-ignore[16]: dis has no _get_code_object
                 _get_code_object(co).co_consts[instr.arg],
                 *instr[4:],
             )
@@ -196,8 +199,10 @@ def assertLoadMethodInBytecode(self, x: Disassembleable, name: str) -> None:
     def assertBinOpInBytecode(self, x: Disassembleable, binop: str) -> None:
         if sys.version_info >= (3, 12):
             binop = "NB_" + binop.removeprefix("BINARY_")
+            # pyre-ignore[21]: unknown _nb_ops
             from opcode import _nb_ops
 
+            # pyre-ignore[16]: unknown _nb_ops
             for i, (name, _sign) in enumerate(_nb_ops):
                 if name == binop:
                     self.assertInBytecode(x, "BINARY_OP", i)
diff --git a/cinderx/PythonLib/test_cinderx/test_compiler/compiler_runtest.py b/cinderx/PythonLib/test_cinderx/test_compiler/compiler_runtest.py
@@ -40,4 +40,5 @@ def open_with_coding(fname):
 
 codeobj = py_compile(text, sys.argv[1], "exec")
 
+# pyre-ignore[6]: maybe not CodeType
 dis_stable.Disassembler().dump_code(codeobj, file=sys.stdout)
diff --git a/cinderx/PythonLib/test_cinderx/test_compiler/test_py37.py b/cinderx/PythonLib/test_cinderx/test_compiler/test_py37.py
@@ -1,4 +1,6 @@
 # Copyright (c) Meta Platforms, Inc. and affiliates.
+# pyre-ignore-all-errors
+
 import __future__
 
 import sys
diff --git a/cinderx/PythonLib/test_cinderx/test_compiler/test_sbs_external.py b/cinderx/PythonLib/test_cinderx/test_compiler/test_sbs_external.py
@@ -41,8 +41,9 @@ def add_test(modname, fname):
     def test_external(self) -> None:
         with open(fname, "rb") as inp:
             encoding, _lines = detect_encoding(inp.readline)
-            code = b"".join(_lines + inp.readlines()).decode(encoding)
+            code = b"".join(list(_lines) + inp.readlines()).decode(encoding)
             node = ast.parse(code, modname, "exec")
+            # pyre-ignore[16]: module doesn't have filename
             node.filename = modname
 
             orig = compile(node, modname, "exec")
@@ -51,6 +52,7 @@ def test_external(self) -> None:
 
             codeobj = py_compile(node, modname, "exec")
             newdump = StringIO()
+            # pyre-ignore[6]: maybe not CodeType
             Disassembler().dump_code(codeobj, newdump)
 
             try:
diff --git a/cinderx/PythonLib/test_cinderx/test_compiler/test_sbs_stdlib.py b/cinderx/PythonLib/test_cinderx/test_compiler/test_sbs_stdlib.py
@@ -58,11 +58,12 @@ def test_stdlib(self) -> None:
                 encoding, _lines = detect_encoding(inp.readline)
             except SyntaxError:
                 return
-            code = b"".join(_lines + inp.readlines()).decode(encoding)
+            code = b"".join(list(_lines) + inp.readlines()).decode(encoding)
             try:
                 node = ast.parse(code, modname, "exec")
             except SyntaxError:
                 return
+            # pyre-ignore[16]: module doesn't have filename
             node.filename = modname
 
             try:
@@ -74,6 +75,7 @@ def test_stdlib(self) -> None:
 
             codeobj = py_compile(node, modname, "exec")
             newdump = StringIO()
+            # pyre-ignore[6]: maybe not CodeType
             Disassembler().dump_code(codeobj, newdump)
 
             try:
diff --git a/cinderx/PythonLib/test_cinderx/test_compiler/test_static/common.py b/cinderx/PythonLib/test_cinderx/test_compiler/test_static/common.py
@@ -407,7 +407,9 @@ def type_error_ctx(
         if offset is not None:
             self.assertEqual(exc.offset, offset)
 
+    # pyre-ignore[34]: missing type variable
     def revealed_type_ctx(self, code: str, type: str) -> ContextManager[None]:
+        # pyre-ignore[7]: bad return type
         return self.type_error_ctx(
             code, rf"reveal_type\(.+\): '{re.escape(type)}'", at="reveal_type("
         )
diff --git a/cinderx/PythonLib/test_cinderx/test_compiler/test_strict/sandbox.py b/cinderx/PythonLib/test_cinderx/test_compiler/test_strict/sandbox.py
@@ -117,8 +117,10 @@ def sandbox(cls: type[_SandboxT] = Sandbox) -> Generator[_SandboxT, None, None]:
 _T = TypeVar("_T")
 
 
+# pyre-ignore[34]: The type variable `Variable[_T]` isn't present in the function's parameters.
 def use_cm(cm_factory: Callable[[], ContextManager[_T]], testcase: TestCase) -> _T:
     cm = cm_factory()
     ret = cm.__enter__()
     testcase.addCleanup(cm.__exit__, None, None, None)
+    # pyre-ignore[7]: Expected `Variable[_T]` but got `Variable[_T_co]`.
     return ret
diff --git a/cinderx/PythonLib/test_cinderx/test_compiler/test_strict/test_rewriter.py b/cinderx/PythonLib/test_cinderx/test_compiler/test_strict/test_rewriter.py
@@ -269,6 +269,7 @@ def test_transitive_closure(self) -> None:
 
     def get_annotations(self, mod: object) -> dict[str, type]:
         if sys.version_info >= (3, 14):
+            # pyre-ignore[21]: Couldn't find annotationlib
             import annotationlib
 
             return annotationlib.get_annotations(mod)
diff --git a/cinderx/PythonLib/test_cinderx/test_compiler/tests.py b/cinderx/PythonLib/test_cinderx/test_compiler/tests.py
@@ -3,13 +3,19 @@
 import sys
 
 from .test_api import ApiTests
+
+# pyre-ignore[21]: test_code_sbs not found (not included in buck test build)
 from .test_code_sbs import CodeTests
 from .test_errors import ErrorTests, ErrorTestsBuiltin
+
+# pyre-ignore[21]: test_exceptiontable not found (not included in buck test build)
 from .test_exceptiontable import EncodingTests
 from .test_flags import FlagTests
 from .test_graph import GraphTests
 from .test_linepos import LinePositionTests
 from .test_optimizer import AstOptimizerTests
+
+# pyre-ignore[21]: test_peephole not found (not included in buck test build)
 from .test_peephole import PeepHoleTests
 from .test_py37 import Python37Tests
 from .test_symbols import SymbolVisitorTests
diff --git a/cinderx/PythonLib/test_cinderx/test_coro_extensions.py b/cinderx/PythonLib/test_cinderx/test_coro_extensions.py
@@ -4,8 +4,9 @@
 import unittest
 
 from cinderx import test_support as cinder_support
-from test.support import import_helper, maybe_get_event_loop_policy
 
+# pyre-ignore[21]: can't find test.support
+from test.support import import_helper, maybe_get_event_loop_policy
 
 if sys.version_info >= (3, 12):
     # in 3.12, awaiter tests are in GetAsyncStackTests in
@@ -84,9 +85,11 @@ async def awaiter():
         self.assertEqual(v1, "future")
         self.assertIsInstance(awaitee_frame, types.FrameType)
         self.assertIsInstance(awaiter_frame, types.FrameType)
+        # pyre-ignore[16]: no attribute _get_frame_gen
         self.assertIs(cinder._get_frame_gen(awaiter_frame), awaiter_obj)
         self.assertIsNone(cinder._get_coro_awaiter(awaiter_obj))
 
+        # pyre-ignore[16]: no attribute _get_frame_gen
         awaitee_obj = cinder._get_frame_gen(awaitee_frame)
         self.assertIsInstance(awaitee_obj, types.CoroutineType)
         self.assertIs(cinder._get_coro_awaiter(awaitee_obj), awaiter_obj)
@@ -108,7 +111,9 @@ async def awaiter2():
 
         self.assertIsInstance(awaitee_frame, types.FrameType)
         self.assertIsInstance(awaiter_frame, types.FrameType)
+        # pyre-ignore[16]: no attribute _get_frame_gen
         awaitee_obj = cinder._get_frame_gen(awaitee_frame)
+        # pyre-ignore[16]: no attribute _get_frame_gen
         awaiter_obj = cinder._get_frame_gen(awaiter_frame)
         self.assertIsInstance(awaitee_obj, types.CoroutineType)
         self.assertIsInstance(awaiter_obj, types.CoroutineType)
diff --git a/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test__opcode.py b/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test__opcode.py
@@ -3,9 +3,12 @@
 import unittest
 
 import cinderx.opcode as opcode
+
+# pyre-ignore[21]: can't find test.support
 from test.support.import_helper import import_module
 
 _opcode = import_module("_opcode")
+# pyre-ignore[21]: can't find _opcode
 from _opcode import stack_effect
 
 
diff --git a/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_asyncgen.py b/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_asyncgen.py
@@ -1,8 +1,10 @@
 # Copyright (c) Meta Platforms, Inc. and affiliates.
 import unittest
 
+# pyre-ignore[21]: can't find test.support
 from test.support import gc_collect
 
+# pyre-ignore[21]: can't find test.support
 from test.support.import_helper import import_module
 
 asyncio = import_module("asyncio")
diff --git a/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_dis.py b/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_dis.py
@@ -13,6 +13,7 @@
     if sys.version_info >= (3, 14):
         import opcode
 
+        # pyre-ignore[16]: No attribute _specialized_opmap
         shadowop = set(opcode._specialized_opmap)
     else:
         shadowop = set()
@@ -190,12 +191,16 @@ def test_widths(self) -> None:
             ):
                 continue
             with self.subTest(opname=opname):
+                # pyre-ignore[16]: no attribute _OPNAME_WIDTH
                 width = dis._OPNAME_WIDTH
                 if sys.version_info >= (3, 12):
+                    # pyre-ignore[16]: unknown hasarg
                     if opcode in dis.hasarg:
+                        # pyre-ignore[16]: no attribute _OPARG_WIDTH
                         width += 1 + dis._OPARG_WIDTH
                 else:
                     if opcode < dis.HAVE_ARGUMENT:
+                        # pyre-ignore[16]: no attribute _OPARG_WIDTH
                         width += 1 + dis._OPARG_WIDTH
                 self.assertLessEqual(len(opname), width)
 
diff --git a/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_fork1.py b/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_fork1.py
@@ -9,15 +9,18 @@
 import time
 import unittest
 
+# pyre-ignore[21]: can't find test.support
 from test import support
 
+# pyre-ignore[21]: can't find test.fork_wait
 from test.fork_wait import ForkWait
 
 
 # Skip test if fork does not exist.
 support.get_attribute(os, "fork")
 
 
+# pyre-ignore[11]: Invalid type ForkWait
 class CinderX_ForkTest(ForkWait):
     def test_threaded_import_lock_fork(self) -> None:
         """Check fork() in main thread works while a subthread is doing an import"""
@@ -59,6 +62,7 @@ def importer():
                 # Exitcode 1 means the child got a partial module (bad.) No
                 # exitcode (but a hang, which manifests as 'got pid 0')
                 # means the child deadlocked (also bad.)
+                # pyre-ignore[16]: no attribute wait_impl
                 self.wait_impl(pid, exitcode=exitcode)
         finally:
             try:
diff --git a/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_gdb.py b/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_gdb.py
@@ -12,6 +12,7 @@
 import sysconfig
 import unittest
 
+# pyre-ignore[21]: can't find test.support
 from test import support
 
 
diff --git a/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_generators.py b/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_generators.py
@@ -2,6 +2,7 @@
 import unittest
 
 try:
+    # pyre-ignore[21]: can't find _testcapi
     import _testcapi
 except ImportError:
     _testcapi = None
@@ -33,6 +34,7 @@ def func():
 
         # modify names of the function creating the generator
         func.__qualname__ = "func_qualname"
+        # pyre-ignore[16]: no attribute __name__
         func.__name__ = "func_name"
         gen = func()
 
@@ -47,7 +49,10 @@ def func():
 
         # unnamed generator
         gen = (x for x in range(10))
+        # pyre-ignore[16]: no attribute __name__
         self.assertEqual(gen.__name__, "<genexpr>")
         self.assertEqual(
-            gen.__qualname__, "CinderX_GeneratorTest.test_name.<locals>.<genexpr>"
+            # pyre-ignore[16]: no attribute __qualname__
+            gen.__qualname__,
+            "CinderX_GeneratorTest.test_name.<locals>.<genexpr>",
         )
diff --git a/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_inspect.py b/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_inspect.py
@@ -10,11 +10,14 @@
 except ImportError:
     ThreadPoolExecutor = None
 
+# pyre-ignore[21]: can't find test.support
 from test.support import cpython_only
 
 try:
+    # pyre-ignore[21]: can't find test
     from test import inspect_fodder as mod
 except ImportError:
+    # pyre-ignore[21]: can't find test.test_inspect
     from test.test_inspect import inspect_fodder as mod
 
 # Functions tested in this suite:
diff --git a/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_repl.py b/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_repl.py
@@ -2,9 +2,13 @@
 import unittest
 from textwrap import dedent
 
+# pyre-ignore[21]: can't find test.support
 from test.support import SuppressCrashReport
+
+# pyre-ignore[21]: can't find test.support
 from test.support.script_helper import kill_python
 
+# pyre-ignore[21]: can't find test.test_repl
 from test.test_repl import spawn_repl
 
 
diff --git a/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_tracemalloc.py b/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_tracemalloc.py
@@ -4,6 +4,7 @@
 import unittest
 
 try:
+    # pyre-ignore[21]: can't find _testcapi
     import _testcapi
 except ImportError:
     _testcapi = None
diff --git a/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_types.py b/cinderx/PythonLib/test_cinderx/test_cpython_overrides/test_types.py
@@ -6,6 +6,7 @@
 import typing
 import unittest.mock
 
+# pyre-ignore[21]: can't find test.support
 from test.support import cpython_only
 
 
@@ -22,7 +23,9 @@ def test_or_type_operator_reference_cycle(self) -> None:
         # CinderX: This is changed from 30 to 1000
         for _ in range(1000):
             T = typing.TypeVar("T")
+            # pyre-ignore[16]: list has no attr __getitem__
             U = int | list[T]
+            # pyre-ignore[16]: TypeVar doesn't have blah
             T.blah = U
             del T
             del U
diff --git a/cinderx/PythonLib/test_cinderx/test_perf_profiler_precompile.py b/cinderx/PythonLib/test_cinderx/test_perf_profiler_precompile.py
diff --git a/cinderx/PythonLib/test_cinderx/test_perfmaps.py b/cinderx/PythonLib/test_cinderx/test_perfmaps.py
diff --git a/cinderx/PythonLib/test_cinderx/test_type_cache.py b/cinderx/PythonLib/test_cinderx/test_type_cache.py

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`# Copyright (c) Meta Platforms, Inc. and affiliates.`
	`2`	`+# pyre-ignore-all-errors`
`2`	`3`
`3`	`4`	`# This script exercises multi-threaded JIT compilation by importing a bunch of`
`4`	`5`	`# things and then calling a magic function on the cinderjit module to do a`
Original file line number	Diff line number	Diff line change
`@@ -91,4 +91,5 @@ def test_duplicates(self) -> None:`
`91`	`91`	`)`
`92`	`92`
`93`	`93`	`def test_iteration(self) -> None:`
	`94`	`+ # pyre-ignore[6]: Incompatible parameter type`
`94`	`95`	`self.assertEqual(set(Shape), {Shape.SQUARE, Shape.CIRCLE})`
Original file line number	Diff line number	Diff line change
`@@ -40,4 +40,5 @@ def open_with_coding(fname):`
`40`	`40`
`41`	`41`	`codeobj = py_compile(text, sys.argv[1], "exec")`
`42`	`42`
	`43`	`+# pyre-ignore[6]: maybe not CodeType`
`43`	`44`	`dis_stable.Disassembler().dump_code(codeobj, file=sys.stdout)`