Skip to content

Commit dc1379c

Browse files
jbower-fbmeta-codesync[bot]
authored andcommitted
Enable PGO + LTO in Sandcastle job
Summary: To make these work we need to make LLVM's runtime profiling library/llvm-ar or a newer version of GCC available on Sandcastle hosts. I've gone with making GCC-14 available as this also matches the cibuildwheel build we have on GitHub and so will help keep our internal and external builds consistent. Reviewed By: alexmalyshev Differential Revision: D87987135 fbshipit-source-id: 5670450efb6fdb6520c828f3ee7ea504a64b79dc
1 parent d474e65 commit dc1379c

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

build/fbcode_builder/getdeps/builder.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1415,6 +1415,10 @@ class SetupPyBuilder(BuilderBase):
14151415
def _build(self, reconfigure) -> None:
14161416
env = self._compute_env()
14171417

1418+
setup_env = self.manifest.get_section_as_dict("setup-py.env", self.ctx)
1419+
for key, value in setup_env.items():
1420+
env[key] = value
1421+
14181422
setup_py_path = os.path.join(self.src_dir, "setup.py")
14191423

14201424
if not os.path.exists(setup_py_path):

build/fbcode_builder/getdeps/manifest.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@
124124
# fb-only
125125
"sandcastle": {"optional_section": True, "fields": {"run_tests": OPTIONAL}},
126126
"setup-py.test": {"optional_section": True, "fields": {"python_script": REQUIRED}},
127+
"setup-py.env": {"optional_section": True},
127128
}
128129

129130
# These sections are allowed to vary for different platforms

build/fbcode_builder/manifests/cinderx-3_14

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,7 @@ fbcode/cinderx/oss_toplevel = .
2222

2323
[setup-py.test]
2424
python_script = cinderx/PythonLib/test_cinderx/test_oss_quick.py
25+
26+
[setup-py.env]
27+
CINDERX_ENABLE_PGO=1
28+
CINDERX_ENABLE_LTO=1

0 commit comments

Comments
 (0)