fix: a lot of instances of clippy::needless_lifetimes

Summary:
This doesn't get all of them because:
1. there are so many of them
2. the lint is pretty jank

Part of facebook/buck2#943

X-link: facebook/buck2#944

Reviewed By: JakobDegen

Differential Revision: D74271655

Pulled By: dtolnay

fbshipit-source-id: c7e41c47248d4be1f5d33a14b676ab35fc5180e2

Author: lf-

examples/cargo.rs

@@ -26,7 +26,7 @@ struct LoadingBar<'a> {
     iteration: usize,
 }
 
-impl<'a> Component for LoadingBar<'a> {
+impl Component for LoadingBar<'_> {
     fn draw_unchecked(
         &self,
 

examples/finalization.rs

@@ -32,7 +32,7 @@ struct StoreName(String);
 #[derive(Display)]
 struct CustomerName(String);
 
-impl<'a> Component for Greeter<'a> {
+impl Component for Greeter<'_> {
     fn draw_unchecked(&self, _dimensions: Dimensions, mode: DrawMode) -> anyhow::Result<Lines> {
         Ok(match mode {
             DrawMode::Normal => {

examples/stylized.rs

@@ -37,7 +37,7 @@ struct StoreName(String);
 #[derive(Display)]
 struct CustomerName(String);
 
-impl<'a> Component for Greeter<'a> {
+impl Component for Greeter<'_> {
     /// Prints a greeting to the current customer.
     fn draw_unchecked(&self, _dimensions: Dimensions, _mode: DrawMode) -> anyhow::Result<Lines> {
         let store_name = self.store_name;

src/components.rs

@@ -77,19 +77,19 @@ impl<C: Component> Component for Box<C> {
     }
 }
 
-impl<'a> Component for &'a dyn Component {
+impl Component for &dyn Component {
     fn draw_unchecked(&self, dimensions: Dimensions, mode: DrawMode) -> anyhow::Result<Lines> {
         (**self).draw_unchecked(dimensions, mode)
     }
 }
 
-impl<'a> Component for &'a (dyn Component + Send) {
+impl Component for &(dyn Component + Send) {
     fn draw_unchecked(&self, dimensions: Dimensions, mode: DrawMode) -> anyhow::Result<Lines> {
         (**self).draw_unchecked(dimensions, mode)
     }
 }
 
-impl<'a, C: Component> Component for &'a C {
+impl<C: Component> Component for &C {
     fn draw_unchecked(&self, dimensions: Dimensions, mode: DrawMode) -> anyhow::Result<Lines> {
         (**self).draw_unchecked(dimensions, mode)
     }

src/content/line.rs

@@ -210,7 +210,7 @@ impl Line {
 
     pub fn fmt_for_test(&self) -> impl Display + '_ {
         struct Impl<'a>(&'a Line);
-        impl<'a> Display for Impl<'a> {
+        impl Display for Impl<'_> {
             fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
                 for span in &self.0.0 {
                     write!(f, "{}", span.fmt_for_test())?;

src/content/lines.rs

@@ -364,7 +364,7 @@ impl Lines {
 
     pub fn fmt_for_test(&self) -> impl Display + '_ {
         struct Impl<'a>(&'a Lines);
-        impl<'a> Display for Impl<'a> {
+        impl Display for Impl<'_> {
             fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
                 for line in self.0.iter() {
                     writeln!(f, "{}", line.fmt_for_test())?;

src/content/span.rs

@@ -288,7 +288,7 @@ impl Span {
         }
 
         struct Impl<'a>(&'a Span);
-        impl<'a> Display for Impl<'a> {
+        impl Display for Impl<'_> {
             fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
                 let style_is_default = self.0.style.foreground_color.is_none()
                     && self.0.style.background_color.is_none()
@@ -353,7 +353,7 @@ impl TryFrom<StyledContent<String>> for Span {
 
 pub(crate) struct SpanIterator<'a>(&'a ContentStyle, Graphemes<'a>, &'a Option<Hyperlink>);
 
-impl<'a> Iterator for SpanIterator<'a> {
+impl Iterator for SpanIterator<'_> {
     type Item = Span;
 
     fn next(&mut self) -> Option<Self::Item> {

src/vec_as_fmt_write.rs

@@ -11,7 +11,7 @@ use std::fmt;
 
 pub(crate) struct VecAsFmtWrite<'a>(pub(crate) &'a mut Vec<u8>);
 
-impl<'a> fmt::Write for VecAsFmtWrite<'a> {
+impl fmt::Write for VecAsFmtWrite<'_> {
     fn write_str(&mut self, s: &str) -> fmt::Result {
         self.0.extend_from_slice(s.as_bytes());
         Ok(())