Skip to content

Commit 022acc1

Browse files
mbasmanovameta-codesync[bot]
authored andcommitted
fix: Rename Type::isUnKnown() to isUnknown() (#16292)
Summary: Pull Request resolved: #16292 Rename the `isUnKnown()` method to `isUnknown()` to fix the typo (capital 'K' should be lowercase 'k'). This brings the method naming in line with other similar methods like `isUnscaledLongDecimal()`, `isOpaque()`, etc. Reviewed By: amitkdutta, natashasehgal Differential Revision: D92610008 fbshipit-source-id: 8c78bec8d94352f8d912c894c741d57465d82702
1 parent b3b3ee2 commit 022acc1

File tree

16 files changed

+22
-22
lines changed

16 files changed

+22
-22
lines changed

velox/exec/fuzzer/AggregationFuzzerBase.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ int32_t AggregationFuzzerBase::randInt(int32_t min, int32_t max) {
9191

9292
bool AggregationFuzzerBase::isSupportedType(const TypePtr& type) const {
9393
// Date / IntervalDayTime/ Unknown are not currently supported by DWRF.
94-
if (type->isDate() || type->isIntervalDayTime() || type->isUnKnown()) {
94+
if (type->isDate() || type->isIntervalDayTime() || type->isUnknown()) {
9595
return false;
9696
}
9797

velox/exec/fuzzer/PrestoQueryRunner.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ const std::vector<TypePtr>& PrestoQueryRunner::supportedScalarTypes() const {
210210

211211
// static
212212
bool PrestoQueryRunner::isSupportedDwrfType(const TypePtr& type) {
213-
if (type->isDate() || type->isIntervalDayTime() || type->isUnKnown() ||
213+
if (type->isDate() || type->isIntervalDayTime() || type->isUnknown() ||
214214
isGeometryType(type)) {
215215
return false;
216216
}

velox/expression/FunctionSignature.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ bool SignatureVariable::isEligibleType(const Type& type) const {
226226
return false;
227227
}
228228

229-
if (knownTypesOnly_ && type.isUnKnown()) {
229+
if (knownTypesOnly_ && type.isUnknown()) {
230230
return false;
231231
}
232232

velox/expression/SimpleFunctionRegistry.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ namespace {
145145

146146
// Same as Type::kindEquals, but matches UNKNOWN in 'physicalType' to any type.
147147
bool physicalTypeMatches(const TypePtr& type, const TypePtr& physicalType) {
148-
if (physicalType->isUnKnown()) {
148+
if (physicalType->isUnknown()) {
149149
return true;
150150
}
151151

velox/functions/lib/ArraySort.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,7 @@ std::shared_ptr<exec::VectorFunction> makeArraySort(
513513
bool nullsFirst,
514514
bool throwOnNestedNull) {
515515
const auto elementType = inputArgs.front().type->childAt(0);
516-
if (elementType->isUnKnown()) {
516+
if (elementType->isUnknown()) {
517517
return createTyped<TypeKind::UNKNOWN>(
518518
inputArgs, ascending, nullsFirst, throwOnNestedNull);
519519
}

velox/functions/prestosql/ArrayDistinct.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ std::shared_ptr<exec::VectorFunction> create(
291291
const core::QueryConfig& /*config*/) {
292292
validateType(inputArgs);
293293
auto elementType = inputArgs.front().type->childAt(0);
294-
if (elementType->isUnKnown()) {
294+
if (elementType->isUnknown()) {
295295
return std::make_shared<ArrayDistinctFunction<UnknownType>>();
296296
}
297297

velox/functions/prestosql/aggregates/ApproxDistinctAggregate.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ std::vector<exec::AggregateRegistrationResult> registerApproxDistinct(
9898
const TypePtr& resultType,
9999
const core::QueryConfig& /*config*/)
100100
-> std::unique_ptr<exec::Aggregate> {
101-
if (argTypes[0]->isUnKnown()) {
101+
if (argTypes[0]->isUnknown()) {
102102
if (hllAsFinalResult) {
103103
return std::make_unique<HyperLogLogAggregate<UnknownValue, true>>(
104104
resultType, hllAsRawInput, defaultError);

velox/functions/prestosql/aggregates/ChecksumAggregate.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,12 +77,12 @@ class ChecksumAggregate : public exec::Aggregate {
7777
}
7878

7979
bool isNullOrNullArray(const TypePtr& type) {
80-
if (type->isUnKnown()) {
80+
if (type->isUnknown()) {
8181
return true;
8282
}
8383
// Only supports null array type for now.
8484
if (type->kind() == TypeKind::ARRAY) {
85-
return type->asArray().elementType()->isUnKnown();
85+
return type->asArray().elementType()->isUnknown();
8686
}
8787
return false;
8888
}

velox/functions/prestosql/aggregates/MergeAggregate.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ std::vector<exec::AggregateRegistrationResult> registerMerge(
8686
if (argTypes[0] == KHYPERLOGLOG()) {
8787
return std::make_unique<MergeKHyperLogLogAggregate>(resultType);
8888
}
89-
if (argTypes[0]->isUnKnown()) {
89+
if (argTypes[0]->isUnknown()) {
9090
return std::make_unique<HyperLogLogAggregate<UnknownValue, true>>(
9191
resultType, hllAsRawInput, defaultError);
9292
}

velox/functions/prestosql/types/JsonCastOperator.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1193,8 +1193,8 @@ bool JsonCastOperator::isSupportedFromType(const TypePtr& other) const {
11931193
}
11941194
return true;
11951195
case TypeKind::MAP:
1196-
if (other->childAt(1)->isUnKnown()) {
1197-
if (other->childAt(0)->isUnKnown()) {
1196+
if (other->childAt(1)->isUnknown()) {
1197+
if (other->childAt(0)->isUnknown()) {
11981198
return true;
11991199
}
12001200
return isSupportedBasicType(other->childAt(0)) &&

0 commit comments

Comments
 (0)