Skip to content

Commit 1a26e8d

Browse files
kgpaimeta-codesync[bot]
authored andcommitted
build: Pre-download gflags source in Ubuntu container image (#16713)
Summary: - Pre-downloads the gflags v2.2.2 source tarball into the Ubuntu Docker image at `/velox/deps-sources/gflags-v2.2.2.tar.gz` - This allows CI jobs that use `gflags_SOURCE=BUNDLED` to set `VELOX_GFLAGS_URL` to the local copy, avoiding a GitHub download on every run - Needed by PR #16424 which switches ubuntu-debug to SYSTEM dependencies with BUNDLED gflags Pull Request resolved: #16713 Test Plan: - [ ] Docker image builds successfully (triggered automatically by this PR) - [ ] Verify the tarball exists at `/velox/deps-sources/gflags-v2.2.2.tar.gz` in the built image Reviewed By: pratikpugalia Differential Revision: D96080928 Pulled By: kgpai fbshipit-source-id: d25d0435ee6f1923408bdf83c45f8ee5fc451356
1 parent b423dc1 commit 1a26e8d

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

scripts/docker/ubuntu-22.04-cpp.dockerfile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,9 @@ RUN apt-get update && \
4747
apt-get update && apt-get install -y -q --no-install-recommends gh && \
4848
apt-get clean && rm -rf /var/lib/apt/lists/*
4949

50+
# Pre-download gflags source for BUNDLED builds to avoid downloading at build time.
51+
RUN mkdir -p /velox/deps-sources && \
52+
curl -fsSL -o /velox/deps-sources/gflags-v2.2.2.tar.gz \
53+
https://github.com/gflags/gflags/archive/refs/tags/v2.2.2.tar.gz
54+
5055
WORKDIR /velox

0 commit comments

Comments
 (0)