fix(ci): Enable posting of claude reviews (#16534)

Summary:
The execution log parsing fails with `Cannot read properties of undefined (reading 'filter')` because the code expected an object with a messages property, but claude-code-base-action writes an array of SDKMessage objects directly to the execution file.

Pull Request resolved: #16534

Reviewed By: kevinwilfong

Differential Revision: D94410061

Pulled By: kgpai

fbshipit-source-id: 80204503a51c750a118183bdbb4313387881c44a

Author: kgpai

.github/workflows/claude-review.yml

@@ -164,8 +164,37 @@ jobs:
           DIFF_STATS: ${{ steps.generate_diff.outputs.diff_stats }}
           IS_TRUNCATED: ${{ steps.generate_diff.outputs.is_truncated }}
         run: |
+          # Create system context first (no variable expansion needed)
+          cat > /tmp/review_prompt.txt << 'PROMPT_EOF'
+          You are an expert C++ code reviewer for the Velox project.
+
+          **IMPORTANT**: First, read the CLAUDE.md file in the repository root. It contains:
+          - Project overview and architecture
+          - Build commands and environment setup
+          - Code style and naming conventions
+          - PR title format requirements
+          - Testing guidelines
+          - Function addition requirements
+
+          Use CLAUDE.md as your primary reference for project-specific standards.
+
+          Key things to know about Velox:
+          - Uses C++20 standard
+          - Heavy use of templates and SFINAE
+          - Custom memory management with MemoryPool
+          - Vectorized execution with custom Vector types
+          - Follows Google C++ style with some modifications
+
+          Provide actionable, specific feedback. Reference exact file paths and line numbers.
+          Be constructive and educational in your feedback.
+          If the diff looks good, say so - don't invent problems.
+
+          ---
+
+          PROMPT_EOF
+
           # Note: Using unquoted PROMPT_EOF to enable variable expansion
-          cat > /tmp/review_prompt.txt << PROMPT_EOF
+          cat >> /tmp/review_prompt.txt << PROMPT_EOF
           Please review the following pull request for the Velox project.
 
           ## Pull Request Information
@@ -233,24 +262,11 @@ jobs:
         uses: anthropics/claude-code-base-action@e8132bc5e637a42c27763fc757faa37e1ee43b34 # beta
         with:
           prompt_file: /tmp/review_prompt.txt
-          system_prompt: |
-            You are an expert C++ code reviewer for the Velox project.
-            Velox is a composable C++ execution engine library for analytical data processing.
-
-            Key things to know about Velox:
-            - Uses C++20 standard
-            - Heavy use of templates and SFINAE
-            - Custom memory management with MemoryPool
-            - Vectorized execution with custom Vector types
-            - Follows Google C++ style with some modifications
-
-            Provide actionable, specific feedback. Reference exact file paths and line numbers.
-            Be constructive and educational in your feedback.
-            If the diff looks good, say so - don't invent problems.
-
-          # Read-only tools only - no Bash, no Edit, no Write
-          allowed_tools: View,GlobTool,GrepTool
-          max_turns: "15"
+          # Use Sonnet 4.6 for code review, with read-only tools and limited turns
+          claude_args: >-
+            --model claude-sonnet-4-6-20250514
+            --max-turns 15
+            --allowedTools View,GlobTool,GrepTool
           anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
 
       # Step 7: Post review as PR comment (skip if dry_run)
@@ -270,21 +286,66 @@ jobs:
 
             try {
               // Read the execution log
-              const executionLog = JSON.parse(fs.readFileSync(process.env.EXECUTION_FILE, 'utf8'));
-
-              // Extract Claude's final response
-              const assistantMessages = executionLog.messages.filter(m => m.role === 'assistant');
-              if (assistantMessages.length > 0) {
-                const lastMessage = assistantMessages[assistantMessages.length - 1];
-                // Handle both string content and array content
-                if (typeof lastMessage.content === 'string') {
-                  reviewBody = lastMessage.content;
-                } else if (Array.isArray(lastMessage.content)) {
-                  reviewBody = lastMessage.content
-                    .filter(block => block.type === 'text')
-                    .map(block => block.text)
-                    .join('\n\n');
+              const fileContent = fs.readFileSync(process.env.EXECUTION_FILE, 'utf8');
+              const executionLog = JSON.parse(fileContent);
+
+              // Log structure for debugging
+              console.log('Execution log type:', Array.isArray(executionLog) ? 'array' : typeof executionLog);
+              if (!Array.isArray(executionLog)) {
+                console.log('Execution log keys:', Object.keys(executionLog));
+              }
+
+              // Helper function to extract text from assistant messages
+              const extractFromMessages = (messages) => {
+                const assistantMessages = messages.filter(m => m.role === 'assistant');
+                if (assistantMessages.length > 0) {
+                  const lastMessage = assistantMessages[assistantMessages.length - 1];
+                  if (typeof lastMessage.content === 'string') {
+                    return lastMessage.content;
+                  } else if (Array.isArray(lastMessage.content)) {
+                    return lastMessage.content
+                      .filter(block => block.type === 'text')
+                      .map(block => block.text)
+                      .join('\n\n');
+                  }
                 }
+                return null;
+              };
+
+              // Try different possible structures from claude-code-base-action
+              if (Array.isArray(executionLog)) {
+                // claude-code-base-action writes messages array directly to file
+                const extracted = extractFromMessages(executionLog);
+                if (extracted) {
+                  reviewBody = extracted;
+                } else {
+                  console.log('No assistant messages found in array');
+                  reviewBody = '⚠️ No assistant response found in execution log.';
+                }
+              } else if (executionLog.result) {
+                // Direct result field
+                reviewBody = executionLog.result;
+              } else if (executionLog.output) {
+                // Output field
+                reviewBody = executionLog.output;
+              } else if (executionLog.response) {
+                // Response field
+                reviewBody = executionLog.response;
+              } else if (executionLog.messages && Array.isArray(executionLog.messages)) {
+                // Messages array inside object
+                const extracted = extractFromMessages(executionLog.messages);
+                if (extracted) {
+                  reviewBody = extracted;
+                } else {
+                  reviewBody = '⚠️ No assistant response found in messages.';
+                }
+              } else if (typeof executionLog === 'string') {
+                // Plain string
+                reviewBody = executionLog;
+              } else {
+                // Fallback: stringify the whole thing
+                console.log('Unknown format, raw content:', JSON.stringify(executionLog).substring(0, 500));
+                reviewBody = '⚠️ Could not parse Claude response format. Check workflow logs for details.';
               }
             } catch (error) {
               console.error('Error parsing execution log:', error);
@@ -332,7 +393,23 @@ jobs:
         run: |
           echo "=== DRY RUN - Review would be posted as comment ==="
           echo ""
-          cat "$EXECUTION_FILE" | jq -r '.messages | map(select(.role == "assistant")) | last | .content' 2>/dev/null || cat "$EXECUTION_FILE"
+          echo "=== Execution file structure ==="
+          # Check if it's an array (claude-code-base-action format) or object
+          if jq -e 'type == "array"' "$EXECUTION_FILE" >/dev/null 2>&1; then
+            echo "Format: array of messages (length: $(jq 'length' "$EXECUTION_FILE"))"
+          else
+            jq 'keys' "$EXECUTION_FILE" 2>/dev/null || echo "Not valid JSON or file not found"
+          fi
+          echo ""
+          echo "=== Attempting to extract review ==="
+          # Try array format first (claude-code-base-action), then object formats
+          if jq -e 'type == "array"' "$EXECUTION_FILE" >/dev/null 2>&1; then
+            # Array format: extract last assistant message content
+            jq -r '[.[] | select(.role == "assistant")] | last | if .content | type == "string" then .content elif .content | type == "array" then [.content[] | select(.type == "text") | .text] | join("\n\n") else "Could not extract" end' "$EXECUTION_FILE" 2>/dev/null || cat "$EXECUTION_FILE"
+          else
+            # Object format: try different possible paths
+            jq -r '.result // .output // .response // .messages[-1].content // "Could not extract"' "$EXECUTION_FILE" 2>/dev/null || cat "$EXECUTION_FILE"
+          fi
           echo ""
           echo "=== End of review ==="