Skip to content

Commit 5edfdda

Browse files
n0r0shimeta-codesync[bot]
authored andcommitted
misc: Move folly/Hash.h include from Type.h to Type.cpp (#16670)
Summary: `Type.h` is one of the most widely included headers in the Velox codebase (200+ downstream files). It included `folly/Hash.h`, which expands to preprocessed lines, but `folly::Hash{}` is only used in `Type.cpp`. This PR moves the include to `Type.cpp` where it actually belongs, following the include-what-you-use (IWYU) principle. Only 3 other files in the codebase directly include `folly/Hash.h`, so this eliminates ~76K preprocessed lines from ~205 translation units. ## Test plan - Full debug build passes (no compilation errors) on CI Pull Request resolved: #16670 Differential Revision: D95972466 Pulled By: peterenescu fbshipit-source-id: 6ea7eefd297387fd7f5f4534f66416085635a9a8
1 parent 731d8fb commit 5edfdda

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

velox/type/Type.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
#pragma once
1717

1818
#include <folly/CPortability.h>
19-
#include <folly/Hash.h>
2019
#include <folly/Random.h>
2120
#include <folly/container/F14Set.h>
2221
#include <folly/dynamic.h>

0 commit comments

Comments
 (0)