Commit 87c8f7e
fix(rpc): Fix CMake header-only library targets for velox_rpc_types and velox_rpc_client (#16748)
Summary:
Pull Request resolved: #16748
#16748
velox_rpc_types and velox_rpc_client are header-only libraries (no .cpp
source files). Without the INTERFACE keyword, CMake cannot determine the
linker language, causing a build failure on macOS:
CMake Error: CMake can not determine linker language for target: velox_rpc_types
Mark both as INTERFACE libraries and use INTERFACE linkage for
velox_rpc_client dependencies.
Reviewed By: xiaoxmeng
Differential Revision: D96329737
fbshipit-source-id: 9a393628980d7c1833afa0d8366867c3ff73402c1 parent 9d598cd commit 87c8f7e
2 files changed
+5
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
| 21 | + | |
26 | 22 | | |
0 commit comments