How to capture all test failures with ctest? #16538
karthikeyann
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Unit tests in Velox CI are run with
ctest. @pedroerp mentioned that If a test crashes, other tests does not run so a test crash does not give full picture of all test failures.Right now, tests are run with
velox/.github/workflows/linux-build-base.yml
Line 198 in 9046fe2
Proposal:
Google test has a feature https://cmake.org/cmake/help/latest/module/GoogleTest.html#command:gtest_discover_tests with cmake support which can let ctest identify individual tests in each google test binary. This allows parallel run of each test possible. The disadvantage of this method is that it will significantly increases our runtime (Needs to be evaluated).
This needs not run for each PR (as developer will investigate a test failure locally anyway), but could be considered for each merged commit runs.
Beta Was this translation helpful? Give feedback.
All reactions