fix: Add blockedWaitFor runtime metrics in Driver::closeByTask()#16711
Closed
spershin wants to merge 1 commit intofacebookincubator:mainfrom
Closed
fix: Add blockedWaitFor runtime metrics in Driver::closeByTask()#16711spershin wants to merge 1 commit intofacebookincubator:mainfrom
spershin wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
amitkdutta
approved these changes
Mar 11, 2026
spershin
pushed a commit
to spershin/velox-1
that referenced
this pull request
Mar 11, 2026
…ebookincubator#16711) Summary: When a query fails and some drivers were blocked we fail to submit the blockedWaitFor runtime metrics. This deprives us from possibly valuable debugging information, such in cases with stuck queries. Reviewed By: vandreykiv, amitkdutta Differential Revision: D96055408
spershin
force-pushed
the
export-D96055408
branch
from
b203ac9 to
f79f0bf
Compare
spershin
pushed a commit
to spershin/velox-1
that referenced
this pull request
Mar 12, 2026
…ebookincubator#16711) Summary: When a query fails and some drivers were blocked we fail to submit the blockedWaitFor runtime metrics. This deprives us from possibly valuable debugging information, such in cases with stuck queries. Reviewed By: vandreykiv, amitkdutta Differential Revision: D96055408
spershin
force-pushed
the
export-D96055408
branch
from
f79f0bf to
2793479
Compare
…ebookincubator#16711) Summary: When a query fails and some drivers were blocked we fail to submit the blockedWaitFor runtime metrics. This deprives us from possibly valuable debugging information, such in cases with stuck queries. Reviewed By: vandreykiv, amitkdutta Differential Revision: D96055408
spershin
force-pushed
the
export-D96055408
branch
from
2793479 to
4425bd0
Compare
xiaoxmeng
approved these changes
Mar 12, 2026
|
This pull request has been merged in e84a676. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When a query fails and some drivers were blocked we fail to submit the
blockedWaitFor runtime metrics.
This deprives us from possibly valuable debugging information, such in cases
with stuck queries.
Differential Revision: D96055408