test: Add makeMapVector overload with explicit offsets and sizes#16749
Closed
pedroerp wants to merge 1 commit intofacebookincubator:mainfrom
Closed
test: Add makeMapVector overload with explicit offsets and sizes#16749pedroerp wants to merge 1 commit intofacebookincubator:mainfrom
pedroerp wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
pedroerp
force-pushed
the
export-D96238549
branch
from
b82a04a to
0df6523
Compare
Summary: Add a new `mapVector(offsets, sizes, keys, values, isNullAt)` overload to `VectorMaker` and the corresponding `makeMapVector` wrapper in `VectorTestBase`. Unlike the existing offsets-only overload (which derives sizes from consecutive offset differences), this variant accepts explicit sizes, enabling construction of MapVectors with non-consecutive or out-of-order layouts — useful for testing code that processes vectors produced by filters, slices, or other transformations. Differential Revision: D96238549
pedroerp
force-pushed
the
export-D96238549
branch
from
0df6523 to
5b689ae
Compare
Yuhta
approved these changes
Mar 12, 2026
|
This pull request has been merged in 22d35f6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add a new
mapVector(offsets, sizes, keys, values, isNullAt)overload toVectorMakerand the correspondingmakeMapVectorwrapper inVectorTestBase. Unlike the existing offsets-only overload (which derivessizes from consecutive offset differences), this variant accepts explicit
sizes, enabling construction of MapVectors with non-consecutive or
out-of-order layouts — useful for testing code that processes vectors
produced by filters, slices, or other transformations.
Differential Revision: D96238549