docs: update veloxcon banner on velox-lib.io#16754
docs: update veloxcon banner on velox-lib.io#16754alileclerc wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
Updating to VeloxCon 2026; added new community tiles at bottom
✅ Deploy Preview for meta-velox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
meta-cla
bot
added
the
CLA Signed
|
@claude /pr-review sorry @alileclerc for the spam, guinea pigging your PR for the claude code action plugin |
|
Claude finished @pratikpugalia's task in 1m 29s —— View job PR Review: Update VeloxCon Banner
SummaryThis PR updates the VeloxCon banner from VeloxCon China 2025 to VeloxCon 2026, refreshes the banner styling from red to a dark blue gradient, and adds five new community news tiles (one event + four blog posts). The Netlify deploy preview looks to be building successfully. Overall the content changes look correct and the new banner design is clean. I left a few minor comments inline: Issues Found1. Accidental An empty 2. Inconsistent indentation in new tiles ( The newly added community tiles (lines 242-275) have inconsistent indentation — content is flush-left or has mixed whitespace, while the existing tiles further down use consistent 12-space indentation. This doesn't affect rendering but hurts readability. 3. Missing trailing newlines ( Both What Looks Good
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| <a href="https://veloxcon.io/" className={styles.newsTile} target="_blank" rel="noopener"> | ||
| <span className={styles.newsTag}>Event</span> | ||
| <h3>VeloxCon 2026</h3> | ||
| <p>Join us at Meta HQ in the Bay Area, April 29-30 for in-person VeloxCon.</p> | ||
| <span className={styles.newsDate}>April 2026</span> | ||
| </a> | ||
|
|
||
| <a href="https://velox-lib.io/blog/regex-hidden-traps" className={styles.newsTile} target="_blank" rel="noopener"> | ||
| <span className={styles.newsTag}>Blog</span> | ||
| <h3>The hidden traps of regex in LIKE and split</h3> | ||
| <p>Both LIKE and Spark's split can silently produce wrong results when used with column values instead of constants.</p> | ||
| <span className={styles.newsDate}>March 2026</span> | ||
| </a> | ||
|
|
||
| <a href="https://velox-lib.io/blog/stringview-api-changes/" className={styles.newsTile} target="_blank" rel="noopener"> | ||
| <span className={styles.newsTag}>Blog</span> | ||
| <h3>velox::StringView API Changes and Best Practices</h3> | ||
| <p>This post describes in more detail how Velox handles columns of strings.</p> | ||
| <span className={styles.newsDate}>February 2026</span> | ||
| </a> | ||
|
|
||
| <a href="https://velox-lib.io/blog/task-barrier/" className={styles.newsTile} target="_blank" rel="noopener"> | ||
| <span className={styles.newsTag}>Blog</span> | ||
| <h3>Task Barrier: Efficient Task Reuse and Streaming Checkpoints in Velox</h3> | ||
| <p>How Velox Task Barriers provide a synchronization mechanism.</p> | ||
| <span className={styles.newsDate}>January 2026</span> | ||
| </a> | ||
|
|
||
| <a href="https://velox-lib.io/blog/why-row-based-sort/" className={styles.newsTile} target="_blank" rel="noopener"> | ||
| <span className={styles.newsTag}>Blog</span> | ||
| <h3>Why Sort is row-based in Velox — A Quantitative Assessment</h3> | ||
| <p>Rationale behind this design decision and provide experimental evidence for its implementation.</p> | ||
| <span className={styles.newsDate}>December 2025</span> | ||
| </a> |
There was a problem hiding this comment.
Nit: The indentation of the newly added tiles is inconsistent with the existing tiles. The new tiles at lines 243-275 use no indentation (content is flush left or uses inconsistent leading whitespace), while older tiles (e.g., lines 319-324) use consistent 12-space indentation for the <a> tag and proper nesting inside.
This won't affect rendering but makes the file harder to maintain. Consider aligning the new tiles to match the existing indentation style.
| "lockfileVersion": 3, | ||
| "requires": true, | ||
| "packages": {} | ||
| } |
There was a problem hiding this comment.
This appears to be an accidentally committed file. The website's package management uses yarn.lock (in the website/ directory), and this empty package-lock.json in the velox/ directory doesn't serve a purpose. It was likely auto-generated by npm running in the wrong directory. Consider removing this file from the PR.
| </section> | ||
| ); | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Nit: Missing newline at end of file. Most editors and linters expect a trailing newline.
| } | |
| } |
| transform: translateY(-1px); | ||
| } | ||
| box-shadow: 0 8px 20px rgba(96,165,250,0.35); | ||
| } No newline at end of file |
There was a problem hiding this comment.
Nit: Missing newline at end of file.
| } | |
| } |
2 participants
Updating to VeloxCon 2026; added new community tiles at bottom