Add tryRegisterNamedVectorSerde() to VectorSerde classes#16757
Open
han-yan01 wants to merge 1 commit intofacebookincubator:mainfrom
Open
Add tryRegisterNamedVectorSerde() to VectorSerde classes#16757han-yan01 wants to merge 1 commit intofacebookincubator:mainfrom
han-yan01 wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@han-yan01 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96412951. |
han-yan01
changed the title
xiaoxmeng
approved these changes
Mar 13, 2026
meta-codesync
bot
changed the title
han-yan01
force-pushed
the
export-D96412951
branch
2 times, most recently
from
7271873 to
ca6b12e
Compare
meta-codesync
bot
changed the title
han-yan01
added a commit
to han-yan01/velox
that referenced
this pull request
Mar 13, 2026
) Summary: Add static name() method to PrestoVectorSerde, CompactRowVectorSerde, and UnsafeRowVectorSerde to provide a compile-time serde name accessor. This allows callers to reference serde names without hardcoding strings. This is extracted from D96046667 as a minimal API addition to unblock axiom migration (D96254285) while the full refactor is reviewed. Reviewed By: xiaoxmeng Differential Revision: D96412951
han-yan01
force-pushed
the
export-D96412951
branch
from
ca6b12e to
a24dbe5
Compare
han-yan01
added a commit
to han-yan01/velox
that referenced
this pull request
Mar 13, 2026
) Summary: Pull Request resolved: facebookincubator#16757 Add static name() method to PrestoVectorSerde, CompactRowVectorSerde, and UnsafeRowVectorSerde to provide a compile-time serde name accessor. This allows callers to reference serde names without hardcoding strings. This is extracted from D96046667 as a minimal API addition to unblock axiom migration (D96254285) while the full refactor is reviewed. Reviewed By: xiaoxmeng Differential Revision: D96412951
han-yan01
force-pushed
the
export-D96412951
branch
from
a24dbe5 to
0da364d
Compare
meta-codesync
bot
changed the title
han-yan01
force-pushed
the
export-D96412951
branch
from
0da364d to
cacd114
Compare
Summary: Add static tryRegisterNamedVectorSerde() method to PrestoVectorSerde, CompactRowVectorSerde, and UnsafeRowVectorSerde. This method checks if the serde is already registered before attempting registration, avoiding duplicate registration errors and simplifying caller code. This is extracted from D96046667 as a minimal API addition to unblock axiom migration (D96254285) while the full refactor is reviewed. Reviewed By: xiaoxmeng Differential Revision: D96412951
han-yan01
force-pushed
the
export-D96412951
branch
from
cacd114 to
ad62ed4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add static tryRegisterNamedVectorSerde() method to PrestoVectorSerde,
CompactRowVectorSerde, and UnsafeRowVectorSerde. This method checks if
the serde is already registered before attempting registration, avoiding
duplicate registration errors and simplifying caller code.
This is extracted from D96046667 as a minimal API addition to unblock
axiom migration (D96254285) while the full refactor is reviewed.
Reviewed By: xiaoxmeng
Differential Revision: D96412951