Reverse Critic deprecation

Instead, we'll just freeze further enhancements to the visualizer

Author: facelessuser

docs/src/markdown/about/changelog.md

@@ -6,6 +6,8 @@ icon: lucide/scroll-text
 ## 10.19
 
 -   **NEW**: Emoji: Update Twemoji to use Unicode 16.
+-   **NEW**: Critic: Roll back `view` mode deprecation as some still like to use it, though further enhancements to this
+    mode are not planned.
 
 ## 10.18
 

docs/src/markdown/extensions/critic.md

@@ -13,15 +13,6 @@ represent edits to a Markdown document.  This extension runs before all other ex
 Critic allows you to automatically accept edits or reject the edits and render the output accordingly. It also allows
 for visually displaying the changes in HTML output ([mileage may vary](#limitations-with-previewing-critic-markup)).
 
-/// warning | Previews Deprecated
-The preview mode has been deprecated, and the default `mode` will be set to `accept` in the future. If you rely on
-Critic, is advised to explicitly set `mode` to either `accept` or `reject` to be protected against any issues related
-to this change in default and removal of the `view` mode in the future.
-
-The `view` mode is being removed simply because support was never that great, and in order to get the quality expected,
-the feature would have to be implemented into the core of Python Markdown, something that is impossible for us to do.
-///
-
 The Critic extension can be included in Python Markdown by using the following:
 
 ```py3
@@ -225,8 +216,8 @@ here:
 The Critic extension does its best by employing a preprocessor to inject the critic tags before all other parsing and a
 post-processor to clean up some of the weird side effects of the injection (only selected odd cases as others are more
 difficult to fix).  It injects some classes into the edit region's HTML output which allows for CSS styling.  There is
-probably a lot more post-processing that could be done to fix more issues, but whether this extension will be going
-further down that road has not yet been decided.
+probably a lot more post-processing that could be done to fix more issues, but there are no plans to enhance the view
+mode any further than it already has been.
 
 ## CSS
 

pymdownx/critic.py

@@ -27,7 +27,6 @@
 from markdown.preprocessors import Preprocessor
 from markdown.postprocessors import Postprocessor
 from markdown.util import STX, ETX
-from .util import warn_deprecated
 import re
 
 SOH = '\u0001'  # start
@@ -297,7 +296,7 @@ def __init__(self, *args, **kwargs):
         self.config = {
             'mode': [
                 'view',
-                "Critic mode to run in: 'view' (deprecated), 'accept' (future default), or 'reject' - Default: view "
+                "Critic mode to run in: 'view', 'accept', or 'reject' - Default: view "
             ],
             'raw_view': [False, "Raw view keeps the output as the raw markup for view mode - Default False"]
         }
@@ -312,12 +311,6 @@ def extendMarkdown(self, md):
         post = CriticsPostprocessor(self.critic_stash)
         critic = CriticViewPreprocessor(self.critic_stash)
         critic.config = self.getConfigs()
-        if critic.config['mode'] == 'view':
-            warn_deprecated(
-                "pymdownx.critic has deprecated the 'view' mode and will default the option to 'accept' "
-                "in the future. It is advised to set the 'mode' option explicitly to either 'accept' or "
-                "'reject' to avoid issues when this change takes place."
-            )
         md.preprocessors.register(critic, "critic", 31.1)
         md.postprocessors.register(post, "critic-post", 25)
         md.registerExtensions(["pymdownx._bypassnorm"], {})

tests/test_extensions/test_critic.py

@@ -1,7 +1,5 @@
 """Test caret."""
 from .. import util
-import pytest
-
 
 class TestCriticViewMode(util.MdCase):
     """Test view mode."""
@@ -15,7 +13,6 @@ class TestCriticViewMode(util.MdCase):
         }
     }
 
-    @pytest.mark.filterwarnings("ignore")
     def test_view(self):
         """Test view mode."""
 
@@ -245,7 +242,6 @@ class TestCriticEscapeAll(util.MdCase):
         }
     }
 
-    @pytest.mark.filterwarnings("ignore")
     def test_escape(self):
         """Test with escapes."""