Cleanup tests

Author: mariuswilms

visitor_test.go

@@ -53,72 +53,55 @@ func TestHandleFailedVisit(t *testing.T) {
 		expectRepublish bool
 	}{
 		{
-			name:            "301 redirect",
-			response:        createTestResponse(301),
-			expectedCode:    CodeIgnore,
-			expectedError:   false,
-			expectPause:     false,
-			expectRepublish: false,
+			name:         "301 redirect",
+			response:     createTestResponse(301),
+			expectedCode: CodeIgnore,
 		},
 		{
-			name:            "404 not found",
-			response:        createTestResponse(404),
-			expectedCode:    CodeIgnore,
-			expectedError:   false,
-			expectPause:     false,
-			expectRepublish: false,
+			name:         "302 redirect",
+			response:     createTestResponse(302),
+			expectedCode: CodeIgnore,
+		},
+		{
+			name:         "404 not found",
+			response:     createTestResponse(404),
+			expectedCode: CodeIgnore,
 		},
 		{
 			name:            "500 internal server error - first retry",
 			response:        createTestResponse(500),
 			retries:         0,
 			expectedCode:    CodeTemporary,
-			expectedError:   false,
-			expectPause:     false,
 			expectRepublish: true,
 		},
 		{
-			name:            "500 internal server error - max retries exceeded",
-			response:        createTestResponse(500),
-			retries:         MaxJobRetries,
-			expectedCode:    CodePermanent,
-			expectedError:   true,
-			expectPause:     false,
-			expectRepublish: false,
+			name:          "500 internal server error - max retries exceeded",
+			response:      createTestResponse(500),
+			retries:       MaxJobRetries,
+			expectedCode:  CodePermanent,
+			expectedError: true,
 		},
 		{
 			name:            "503 service unavailable with retry-after",
 			response:        createTestResponse(503, "Retry-After", "60"),
 			expectedCode:    CodeTemporary,
-			expectedError:   false,
 			expectPause:     true,
 			expectRepublish: true,
 		},
 		{
-			name:            "context deadline exceeded",
-			response:        nil,
-			err:             context.DeadlineExceeded,
-			expectedCode:    CodeTemporary,
-			expectedError:   false,
-			expectPause:     false,
-			expectRepublish: true,
+			name:         "context deadline exceeded",
+			err:          context.DeadlineExceeded,
+			expectedCode: CodeTemporary,
 		},
 		{
-			name:            "unknown status code",
-			response:        createTestResponse(418), // I'm a teapot
-			expectedCode:    CodeUnknown,
-			expectedError:   false,
-			expectPause:     false,
-			expectRepublish: false,
+			name:         "unknown status code",
+			response:     createTestResponse(418), // I'm a teapot
+			expectedCode: CodeUnknown,
 		},
 		{
-			name:            "unhandled error without response",
-			response:        nil,
-			err:             errors.New("random error"),
-			expectedCode:    CodeUnhandled,
-			expectedError:   true,
-			expectPause:     false,
-			expectRepublish: false,
+			name:         "unhandled error without response",
+			err:          errors.New("random error"),
+			expectedCode: CodeUnhandled,
 		},
 	}