Skip to content

Commit 5dd0332

Browse files
spasumarthi21GitHub Enterprise
authored andcommitted
fix(r): CRAN warnings and comments (#14)
* Using a person's email Id for Maintainer role. * Incremented the patch version. * Improved description and added executable examples.
1 parent b2e8555 commit 5dd0332

File tree

5 files changed

+57
-5
lines changed

5 files changed

+57
-5
lines changed
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
Makefile
1+
^Makefile$
2+
^cran-comments\.md$

r/factset.protobuf.stach/DESCRIPTION

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
11
Package: factset.protobuf.stach
22
Type: Package
3-
Title: FactSet's STACH Library
4-
Version: 1.0.1
3+
Title: 'FactSet' 'STACH' Library
4+
Version: 1.0.2
55
Author: analytics-reporting
6-
Maintainer: Analytics API Support <analytics.api.support@factset.com>
7-
Description: Generates RProtobuf classes for FactSet's STACH tabular format.
6+
Maintainer: Charlie Mathis<chmathis@factset.com>
7+
Description: Generates 'RProtobuf' classes for 'FactSet' 'STACH' tabular
8+
format which represents complex multi-dimensional array of data. These
9+
classes help in the 'serialization' and 'deserialization' of 'STACH'
10+
formatted data. See 'GitHub' repository documentation for more
11+
information.
812
URL: https://github.com/factset/stachschema
913
BugReports: https://github.com/factset/stachschema/issues
1014
License: Apache License 2.0

r/factset.protobuf.stach/R/NullValues.R

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,21 @@
99
#' @field STRING Null value for STRING data type
1010
#' @field TIMESTAMP Null value for TIMESTAMP data type
1111
#' @field DURATION Null value for DURATION data type
12+
#' @examples
13+
#' nullValues <- factset.protobuf.stach.NullValues$new()
14+
#'
15+
#' # Null value comparison for Protobuf's String data type.
16+
#' a <- 'null'
17+
#' if(nullValues$STRING == a) print("a is the null") else print("a is not a null")
18+
#'
19+
#' # Null value comparison for Protobuf's Int32 data type.
20+
#' b <- new(google.protobuf.Int32Value, value = 2147483647)
21+
#' if(nullValues$INT32 == b$value) print("b is the null") else print("b is not a null")
22+
#'
23+
#' # Null value comparison for Protobuf's Duration data type.
24+
#' c <- new(google.protobuf.Duration, seconds = 315576000000, nanos = 999999900)
25+
#' if(nullValues$DURATION == c) print("c is the null") else print("c is not a null")
26+
#' @importFrom R6 R6Class
1227
#' @export
1328
factset.protobuf.stach.NullValues <- R6::R6Class(
1429
'factset.protobuf.stach.NullValues',
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
## Resubmission
2+
3+
This is a resubmission. Following things were fixed as per the previous feedback.
4+
5+
* Used a single person's email Id for the package maintainer field.
6+
* Improved the package description.
7+
* Used single quotes for package, software and API names in the title and description fields.
8+
* Added examples in the .Rd files.
9+
10+
## Test environments
11+
* local Windows install - R 3.5.1
12+
* win-builder (devel and release)
13+
14+
## R CMD check results
15+
There were no ERRORs or WARNINGS
16+
17+
There was 1 NOTE: New submission.

r/factset.protobuf.stach/man/factset.protobuf.stach.NullValues.Rd

Lines changed: 15 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)