Appease mypy (lots of Lists to Sequences)

Author: lampholder

src/faff_cli/intent.py

@@ -12,6 +12,7 @@
 from faff_cli.output import create_formatter
 from faff_cli.filtering import FilterConfig, apply_filters
 from faff_cli.ui import fuzzy_select
+from faff_cli.ui.fuzzy_select import FuzzyItem
 from faff_cli.start import nicer, nicer_tracker
 
 from faff_core import Workspace, Filter
@@ -665,11 +666,11 @@ def complete(
 
             # Let user select which one to complete
             choices = [
-                {
-                    "name": f"{intent.alias} (missing: {', '.join([f for f in ['role', 'objective', 'action', 'subject'] if not getattr(intent, f)])})",
-                    "value": intent.intent_id,
-                    "decoration": intent.intent_id
-                }
+                FuzzyItem(
+                    name=f"{intent.alias} (missing: {', '.join([f for f in ['role', 'objective', 'action', 'subject'] if not getattr(intent, f)])})",
+                    value=intent.intent_id,
+                    decoration=intent.intent_id
+                )
                 for intent in incomplete_intents
             ]
 

src/faff_cli/main.py

@@ -1,5 +1,6 @@
 import typer
 import humanize
+from typing import Any
 
 from faff_cli import log, id, plan, start, timesheet, intent, field, remote, plugin, reflect, session
 from faff_cli.utils import edit_file
@@ -394,7 +395,7 @@ def status(ctx: typer.Context):
 
         if stale:
             # Group by audience
-            by_audience = {}
+            by_audience: dict[str, list[Any]] = {}
             for ts in stale:
                 if ts.meta.audience_id not in by_audience:
                     by_audience[ts.meta.audience_id] = []

src/faff_cli/output.py

@@ -9,7 +9,7 @@
 
 import json
 import sys
-from typing import Any, Dict, List, Optional
+from typing import Any, Dict, List, Optional, Sequence
 from rich.console import Console
 from rich.table import Table
 
@@ -32,7 +32,7 @@ def __init__(self, json_mode: bool = False, plain_mode: bool = False):
     def print_table(
         self,
         data: List[Dict[str, Any]],
-        columns: List[tuple[str, str, Optional[str]]],  # (key, title, style)
+        columns: Sequence[tuple[str, str, Optional[str]]],  # (key, title, style)
         title: Optional[str] = None,
         total_label: Optional[str] = None,
     ):
@@ -142,7 +142,10 @@ def print_warning(self, message: str):
             if self.plain_mode:
                 print(formatted, file=sys.stderr)
             else:
-                self.console.print(f"[yellow]{formatted}[/yellow]", file=sys.stderr)
+                # Rich Console doesn't support file parameter, use stderr console
+                from rich.console import Console
+                stderr_console = Console(stderr=True)
+                stderr_console.print(f"[yellow]{formatted}[/yellow]")
 
     # Private methods
 
@@ -153,7 +156,7 @@ def _print_json(self, data: Any):
     def _print_rich_table(
         self,
         data: List[Dict[str, Any]],
-        columns: List[tuple[str, str, Optional[str]]],
+        columns: Sequence[tuple[str, str, Optional[str]]],
         title: Optional[str],
         total_label: Optional[str],
     ):
@@ -182,7 +185,7 @@ def _print_rich_table(
     def _print_plain_table(
         self,
         data: List[Dict[str, Any]],
-        columns: List[tuple[str, str, Optional[str]]],
+        columns: Sequence[tuple[str, str, Optional[str]]],
     ):
         """Print data as tab-separated plain text."""
         # Print header

src/faff_cli/ui/fuzzy_select.py

@@ -12,7 +12,7 @@
 from prompt_toolkit.shortcuts import print_formatted_text
 from prompt_toolkit.formatted_text import HTML
 
-from typing import Union, Any, Optional, List
+from typing import Union, Any, Optional, List, Sequence
 from dataclasses import dataclass
 
 from pfzy import fzy_scorer
@@ -32,22 +32,22 @@ class FuzzyItem:
     decoration: Optional[str] = None
     is_new: bool = False
 
-def is_list_of_strs(items: List[Any]) -> bool:
+def is_list_of_strs(items: Sequence[Any]) -> bool:
     return all(isinstance(i, str) for i in items)
 
-def is_list_of_dicts(items: List[Any]) -> bool:
+def is_list_of_dicts(items: Sequence[Any]) -> bool:
     return all(isinstance(i, dict) and "name" in i and "value" in i for i in items)
 
-def is_list_of_dataclasses(items: List[Any]) -> bool:
+def is_list_of_dataclasses(items: Sequence[Any]) -> bool:
     return all(isinstance(i, FuzzyItem) for i in items)
 
-def normalize_to_fuzzyitems(items: List[Any]) -> List[FuzzyItem]:
+def normalize_to_fuzzyitems(items: Sequence[Any]) -> List[FuzzyItem]:
     if is_list_of_strs(items):
         return [FuzzyItem(name=i, value=i) for i in items]
     elif is_list_of_dicts(items):
         return [FuzzyItem(name=i["name"], value=i.get("value", i["name"]), decoration=i.get("decoration")) for i in items]
     elif is_list_of_dataclasses(items):
-        return items[:]
+        return list(items)
     else:
         raise TypeError("Expected list of str, dicts with name/value, or FuzzyItem instances")
 
@@ -56,7 +56,7 @@ def slugify_preserving_slashes(path: str, **kwargs) -> str:
     return "/".join(slugify(seg, **kwargs) for seg in segments)
 
 def fuzzy_select(prompt: str,
-                 choices: List[Union[str, FuzzyItem]],
+                 choices: Sequence[Union[str, FuzzyItem]],
                  create_new: bool = True,
                  max_fraction: float = 0.5,
                  escapable: bool = True,