Make protocol selection spec complaint

martenrichter · martenrichter · commit a74f912b6f93 · 2025-12-13T20:33:05.000+01:00
diff --git a/main/lib/session.js b/main/lib/session.js
@@ -278,8 +278,8 @@ export class HttpWTSession {
     /** @type {Map<bigint,WebTransportSendGroup>} */
     this._sendGroupIndex = new Map()
 
-    /** @type {undefined|string} */
-    this._selectedProtocol = undefined
+    /** @type {string} */
+    this._selectedProtocol = ''
   }
 
   /**
diff --git a/main/lib/webtransport.browser.js b/main/lib/webtransport.browser.js
@@ -364,7 +364,7 @@ export class WebTransportPolyfill {
   }
 
   get protocol() {
-    return this.curtransport?.protocol || undefined
+    return this.curtransport?.protocol || ''
   }
 
   getStats() {
diff --git a/test/session.spec.js b/test/session.spec.js
@@ -168,7 +168,7 @@ describe('session', function () {
       console.log('Application protocol is not implemented skipping')
       return // not implemented is also fine
     }
-    expect(client.protocol).to.equal(undefined)
+    expect(client.protocol).to.equal('')
     await client.closed
   })
   if (browser !== 'chromium' && browser !== 'firefox' && browser !== 'webkit') {

Original file line number	Diff line number	Diff line change
`@@ -278,8 +278,8 @@ export class HttpWTSession {`
`278`	`278`	`/** @type {Map<bigint,WebTransportSendGroup>} */`
`279`	`279`	`this._sendGroupIndex = new Map()`
`280`	`280`
`281`		`- /** @type {undefined\|string} */`
`282`		`- this._selectedProtocol = undefined`
	`281`	`+ /** @type {string} */`
	`282`	`+ this._selectedProtocol = ''`
`283`	`283`	`}`
`284`	`284`
`285`	`285`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -364,7 +364,7 @@ export class WebTransportPolyfill {`
`364`	`364`	`}`
`365`	`365`
`366`	`366`	`get protocol() {`
`367`		`- return this.curtransport?.protocol \|\| undefined`
	`367`	`+ return this.curtransport?.protocol \|\| ''`
`368`	`368`	`}`
`369`	`369`
`370`	`370`	`getStats() {`
Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ describe('session', function () {`
`168`	`168`	`console.log('Application protocol is not implemented skipping')`
`169`	`169`	`return // not implemented is also fine`
`170`	`170`	`}`
`171`		`- expect(client.protocol).to.equal(undefined)`
	`171`	`+ expect(client.protocol).to.equal('')`
`172`	`172`	`await client.closed`
`173`	`173`	`})`
`174`	`174`	`if (browser !== 'chromium' && browser !== 'firefox' && browser !== 'webkit') {`