Use new machine-name path (#581)

Author: sonnyp

device-backend/control/adafruithat/planktoscope/identity.py

@@ -1,5 +1,5 @@
 # TODO: keep this as the default path, but allow changing it with an environment variable
-MACHINE_NAME_PATH = '/var/lib/planktoscope/machine-name'
+MACHINE_NAME_PATH = '/run/machine-name'
 
 def load_machine_name(path=MACHINE_NAME_PATH):
     """Returns the machine name specified by the file at MACHINE_NAMEPATH.

device-backend/control/planktoscopehat/planktoscope/identity.py

@@ -1,5 +1,5 @@
 # TODO: keep this as the default path, but allow changing it with an environment variable
-MACHINE_NAME_PATH = '/var/lib/planktoscope/machine-name'
+MACHINE_NAME_PATH = '/run/machine-name'
 
 def load_machine_name(path=MACHINE_NAME_PATH):
     """Returns the machine name specified by the file at MACHINE_NAMEPATH.

device-backend/processing/segmenter/planktoscope/identity.py

@@ -1,5 +1,5 @@
 # TODO: keep this as the default path, but allow changing it with an environment variable
-MACHINE_NAME_PATH = '/var/lib/planktoscope/machine-name'
+MACHINE_NAME_PATH = '/run/machine-name'
 
 def load_machine_name(path=MACHINE_NAME_PATH):
     """Returns the machine name specified by the file at MACHINE_NAMEPATH.

software/distro/setup/planktoscope-app-env/node-red-frontend/install.sh

@@ -20,15 +20,6 @@ case "$hardware_type" in
   ;;
 esac
 
-# Prepare tool to generate machine names based on serial numbers
-# Note: the tool itself is deployed/managed by Forklift.
-# TODO: remove this by updating the Node-RED frontend and Python backend:
-# Add a symlink at /var/lib/planktoscope/machine-name for backwards-compatibility with the Node-RED
-# frontend and Python backend, which are not yet updated to check /run/machine-name instead:
-sudo mkdir -p /var/lib/planktoscope
-sudo rm -f /var/lib/planktoscope/machine-name
-sudo ln -s /run/machine-name /var/lib/planktoscope/machine-name
-
 # Install dependencies
 # smbus is needed by some python3 nodes in the Node-RED dashboard for the Adafruit HAT.
 # Since the Node-RED systemd service runs as the pi user by default (and we don't override that

software/node-red-dashboard/adafruithat/flows.json

@@ -7884,7 +7884,7 @@
         "type": "file in",
         "z": "1371dec5.76e671",
         "name": "Get machine name",
-        "filename": "/var/lib/planktoscope/machine-name",
+        "filename": "/run/machine-name",
         "filenameType": "str",
         "format": "utf8",
         "chunk": false,

software/node-red-dashboard/planktoscopehat/flows.json

@@ -7743,7 +7743,7 @@
         "type": "file in",
         "z": "1371dec5.76e671",
         "name": "Get machine name",
-        "filename": "/var/lib/planktoscope/machine-name",
+        "filename": "/run/machine-name",
         "filenameType": "str",
         "format": "utf8",
         "chunk": false,