Merge pull request #114 from faithcomesbyhearing/69659-cov-obt-not-combine

Author: robertoSolaresFSL

service/copyright/copyright.go

@@ -45,8 +45,22 @@ const (
 	// Dependency directions.
 	DirectionSuccessor   = "successor"
 	DirectionPredecessor = "predecessor"
+
+	// Covenant stocknumbers.
+	RegularCovenantSuffix     = "/COV"
+	AlternativeCovenantSuffix = `/CV\d+$`
+
+	// OBT stocknumbers.
+	RegularOBTSuffix     = "/LPF"
+	AlternativeOBTSuffix = "/LFP"
+
+	// Creative Commons copyright.
+	CreativeCommonsCopyright            = " CC BY"
+	AlternativeCreativeCommonsCopyright = " CC0"
 )
 
+var CovenantRegex = regexp.MustCompile(AlternativeCovenantSuffix)
+
 type Package struct {
 	Products []string `form:"productList"`
 }
@@ -76,6 +90,7 @@ type dependentCopyright struct {
 	LicenseGroupCopyright string               `json:"licenseGroupCopyright"`
 	ProposedCopyright     string               `json:"proposedCopyright"`
 	IsCombinedCopyright   bool                 `json:"isCombinedCopyright"`
+	CanBeCombined         bool                 `json:"canBeCombined"`
 	DependentCopyrights   []dependentCopyright `json:"dependentCopyrights,omitempty"`
 }
 
@@ -84,6 +99,7 @@ type Dependency struct {
 	RawCopyright        string               `json:"rawCopyright"`
 	CurrentCopyright    string               `json:"currentCopyright"`
 	IsCombinedCopyright bool                 `json:"isCombinedCopyright"`
+	CanBeCombined       bool                 `json:"canBeCombined"`
 	DependentCopyrights []dependentCopyright `json:"dependentCopyrights"`
 }
 
@@ -865,11 +881,18 @@ func (m *Manager) GetCopyrightDependency(
 		rawCopyright = copyrightRows[0].Copyright.String
 	}
 
+	canBeCombined := copyrightCanBeCombined(
+		copyrightRows[0].ModeID,
+		copyrightRows[0].Stocknumber.String,
+		dependents,
+	)
+
 	out := Dependency{
 		LicenseGroupName:    copyrightRows[0].Name,
 		RawCopyright:        rawCopyright,
 		CurrentCopyright:    copyrightRows[0].Copyright.String,
 		IsCombinedCopyright: isCombinedCopyright,
+		CanBeCombined:       canBeCombined,
 		DependentCopyrights: dependents,
 	}
 
@@ -1047,11 +1070,18 @@ func (m *Manager) processDependentCopyright(
 		return nil, err
 	}
 
+	canBeCombined := copyrightCanBeCombined(
+		copyrightRows[0].ModeID,
+		copyrightRows[0].Stocknumber.String,
+		nestedDependents,
+	)
+
 	return &dependentCopyright{
 		LicenseGroupID:        int(row.LicenseGroupID),
 		LicenseGroupName:      row.LicenseGroupName,
 		LicenseGroupCopyright: row.Copyright.String,
 		IsCombinedCopyright:   isCombinedCopyright,
+		CanBeCombined:         canBeCombined,
 		ProposedCopyright:     proposedCopyright,
 		DependentCopyrights:   nestedDependents,
 	}, nil
@@ -1308,3 +1338,53 @@ func removeDependentDuplicates(
 
 	return noDuplicates
 }
+
+// copyrightCanBeCombined determines if the copyright can be combined
+// based on mode, stocknumber, and dependents.
+func copyrightCanBeCombined(
+	modeID uint8,
+	stocknumber string,
+	dependents []dependentCopyright,
+) bool {
+	// Only Video filesets may not be combined
+	if modeID != ModeVideoID {
+		return true
+	}
+
+	// COV and OBT filesets cannot be combined
+	if stocknumberIsCovenant(stocknumber) || stocknumberIsOBT(stocknumber) {
+		return false
+	}
+
+	// Standalone filesets cannot be combined
+	if len(dependents) == 0 {
+		return false
+	}
+
+	// If any dependent has Creative Commons copyright, it cannot be combined
+	for _, dependent := range dependents {
+		if copyrightHasCCLicense(dependent.LicenseGroupCopyright) {
+			return false
+		}
+	}
+
+	return true
+}
+
+// stocknumberIsCovenant checks if the stocknumber indicates a Covenant fileset.
+func stocknumberIsCovenant(stocknumber string) bool {
+	return strings.HasSuffix(stocknumber, RegularCovenantSuffix) ||
+		CovenantRegex.MatchString(stocknumber)
+}
+
+// stocknumberIsOBT checks if the stocknumber indicates an OBT fileset.
+func stocknumberIsOBT(stocknumber string) bool {
+	return strings.HasSuffix(stocknumber, RegularOBTSuffix) ||
+		strings.HasSuffix(stocknumber, AlternativeOBTSuffix)
+}
+
+// copyrightHasCCLicense checks if the copyright contains a Creative Commons license.
+func copyrightHasCCLicense(copyright string) bool {
+	return strings.Contains(copyright, CreativeCommonsCopyright) ||
+		strings.Contains(copyright, AlternativeCreativeCommonsCopyright)
+}

sqlc/generated/copyright.sql.go

@@ -34,10 +34,13 @@ SELECT DISTINCT
   lg.copyright,
   lg.is_copyright_combined,
   bf.mode_id,
-  bf.set_size_code AS size
+  bf.set_size_code AS size,
+  bft.description AS stocknumber
 FROM
   license_group lg
   INNER JOIN bible_filesets bf ON lg.id = bf.license_group_id
+  LEFT JOIN bible_fileset_tags bft ON bft.hash_id = bf.hash_id
+  AND bft.name = 'stock_no'
 WHERE
   lg.id = sqlc.arg('license_group_id');