Skip to content

Commit 2dbb722

Browse files
committed
Disable hiding symbols & inlines
* Having the '-fvisibility=hidden' and '-fvisibility-inlines-hidden' flags enabled gives clang warnings, regardless of the project's visibility settings. Figure there's really no reason to hide Boost's symbols anyways, since it's just being linked into a different project anyways.
1 parent 7984a2b commit 2dbb722

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

boost.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1013,7 +1013,6 @@ fi
10131013

10141014
# Must set these after parseArgs to fill in overriden values
10151015
EXTRA_FLAGS="-DBOOST_AC_USE_PTHREADS -DBOOST_SP_USE_PTHREADS -g -DNDEBUG"`
1016-
`" -fvisibility=hidden -fvisibility-inlines-hidden"`
10171016
`" -Wno-unused-local-typedef -fembed-bitcode -Wno-nullability-completeness"
10181017
EXTRA_IOS_FLAGS="$EXTRA_FLAGS -mios-version-min=$MIN_IOS_VERSION"
10191018
EXTRA_TVOS_FLAGS="$EXTRA_FLAGS -mtvos-version-min=$MIN_TVOS_VERSION"

changelog

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
-- 2018-08-21 --
2+
* Disabled hiding symbols & inlines
3+
- This was causing clang to throw warnings, regardless of the project's
4+
visibility settings. I don't see any reason it needs to be enabled
5+
anyways.
6+
7+
If this causes a problem for your project let me know and I will add a
8+
CLI flag to optionally add them back in (or just do it yourself &
9+
submit a PR!)
10+
111
-- 2018-08-15 --
212
* Fixed universal build to allow for build directories that contain spaces
313

0 commit comments

Comments
 (0)