Skip to content

Commit 9e7604c

Browse files
committed
Letter 1.1.0
1 parent 4b64cda commit 9e7604c

File tree

5 files changed

+23
-6
lines changed

5 files changed

+23
-6
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
<a name="1.1.0"></a>
2+
# [1.1.0](https://github.com/faker-javascript/letter) (2022-01-08)
3+
* Add locales support: ru_RU, en_US (default)
4+
15
<a name="1.0.1"></a>
26
# [1.0.1](https://github.com/faker-javascript/letter) (2022-01-08)
37
* Package fixes

README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,13 @@ $ npm install --save @fakerjs/letter
1818
import fakeLetter from '@fakerjs/letter';
1919

2020
fakeLetter();
21-
//=> a
21+
//=> z
2222

2323
fakeLetter({'casing': 'upper'});
24-
//=> A
24+
//=> Z
25+
26+
fakeLetter({'casing': 'upper', 'locale': 'ru_RU'});
27+
//=> Я
2528
```
2629

2730
## Tests

index.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
export default function fakeLetter(options) {
2-
let keyspace = "abcdefghijklmnopqrstuvwxyz";
3-
let letter = keyspace.charAt(Math.floor(Math.random() * keyspace.length));
42
options = options || {};
3+
let keyspace = {
4+
"en_US": "abcdefghijklmnopqrstuvwxyz",
5+
"ru_RU": "абвгдеёжзийклмнопрстуфхцчшщъыьэюя"
6+
};
7+
let locale = ((options.locale === undefined) ? 'en_US' : options.locale);
8+
let letter = keyspace[locale].charAt(Math.floor(Math.random() * keyspace[locale].length));
59
return (options.casing === 'upper' ? letter.toUpperCase() : letter);
610
};

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@fakerjs/letter",
3-
"version": "1.0.1",
3+
"version": "1.1.0",
44
"description": "Letter package provides functionality to generate a fake letter value.",
55
"license": "MIT",
66
"repository": "faker-javascript/letter",

test.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,14 @@ test('fakeLetter return type to be string', t => {
55
t.is(typeof fakeLetter(), 'string');
66
});
77

8-
test('fakeLetter string length less eq 1', t => {
8+
test('fakeLetter length casing eq 1', t => {
99
t.is(fakeLetter().length, 1);
1010
t.is(fakeLetter({ casing: 'upper' }).length, 1);
1111
t.is(fakeLetter({ casing: 'lower' }).length, 1);
1212
});
13+
14+
test('fakeLetter with casing and locale ru_RU length eq 1', t => {
15+
t.is(fakeLetter().length, 1);
16+
t.is(fakeLetter({ casing: 'upper', locale: 'ru_RU' }).length, 1);
17+
t.is(fakeLetter({ casing: 'lower', locale: 'ru_RU' }).length, 1);
18+
});

0 commit comments

Comments
 (0)