deps: update dev dependencies (#3078)

* deps: update dependencies
* chore: update `rubocop.yml` according to migration guide

Updates RuboCop extension cops specified in configuration files like
`.rubocop.yml`, changing it from `require` to `plugins`.

See https://docs.rubocop.org/rubocop/plugin_migration_guide.html

* deps: bump `rubocop` to `v1.75.4`

Upgrade rubocop version to `v1.75.4` and fix Rubocop errors.

Author: thdaraujo

.rubocop.yml

@@ -1,4 +1,4 @@
-require:
+plugins:
   - rubocop-minitest
   - rubocop-rake
 

Gemfile

@@ -6,13 +6,13 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'benchmark'
-gem 'minitest', '5.25.4'
+gem 'minitest', '5.25.5'
 gem 'pry', '0.15.2'
 gem 'rake', '13.2.1'
-gem 'rubocop', '1.73.0'
-gem 'rubocop-minitest', '0.37.0'
+gem 'rubocop', '1.75.4'
+gem 'rubocop-minitest', '0.37.1'
 gem 'rubocop-rake', '0.7.1'
 gem 'simplecov', '0.22.0'
-gem 'test-unit', '3.6.7'
+gem 'test-unit', '3.6.8'
 gem 'timecop', '0.9.10'
 gem 'yard', '0.9.37'

Gemfile.lock

@@ -7,46 +7,48 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    ast (2.4.2)
+    ast (2.4.3)
     benchmark (0.4.0)
     coderay (1.1.3)
     concurrent-ruby (1.3.5)
-    docile (1.4.0)
+    docile (1.4.1)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.10.1)
+    json (2.11.3)
     language_server-protocol (3.17.0.4)
     lint_roller (1.1.0)
     method_source (1.1.0)
-    minitest (5.25.4)
-    parallel (1.26.3)
-    parser (3.3.7.1)
+    minitest (5.25.5)
+    parallel (1.27.0)
+    parser (3.3.8.0)
       ast (~> 2.4.1)
       racc
     power_assert (2.0.5)
+    prism (1.4.0)
     pry (0.15.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
     racc (1.8.1)
     rainbow (3.1.1)
     rake (13.2.1)
     regexp_parser (2.10.0)
-    rubocop (1.73.0)
+    rubocop (1.75.4)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.38.1)
-      parser (>= 3.3.1.0)
-    rubocop-minitest (0.37.0)
+    rubocop-ast (1.44.1)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    rubocop-minitest (0.37.1)
       lint_roller (~> 1.1)
-      rubocop (>= 1.61, < 2.0)
+      rubocop (>= 1.72.1, < 2.0)
       rubocop-ast (>= 1.38.0, < 2.0)
     rubocop-rake (0.7.1)
       lint_roller (~> 1.1)
@@ -56,9 +58,9 @@ GEM
       docile (~> 1.1)
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
-    simplecov-html (0.12.3)
+    simplecov-html (0.13.1)
     simplecov_json_formatter (0.1.4)
-    test-unit (3.6.7)
+    test-unit (3.6.8)
       power_assert
     timecop (0.9.10)
     unicode-display_width (3.1.4)
@@ -73,14 +75,14 @@ PLATFORMS
 DEPENDENCIES
   benchmark
   faker!
-  minitest (= 5.25.4)
+  minitest (= 5.25.5)
   pry (= 0.15.2)
   rake (= 13.2.1)
-  rubocop (= 1.73.0)
-  rubocop-minitest (= 0.37.0)
+  rubocop (= 1.75.4)
+  rubocop-minitest (= 0.37.1)
   rubocop-rake (= 0.7.1)
   simplecov (= 0.22.0)
-  test-unit (= 3.6.7)
+  test-unit (= 3.6.8)
   timecop (= 0.9.10)
   yard (= 0.9.37)
 

lib/faker/default/code.rb

@@ -168,6 +168,7 @@ def sin
 
       # Reporting body identifier
       RBI = %w[01 10 30 33 35 44 45 49 50 51 52 53 54 86 91 98 99].freeze
+      private_constant :RBI
 
       def generate_imei
         str = Array.new(15, 0)
@@ -269,7 +270,10 @@ def generate_base13_ean
       end
 
       EAN_CHECK_DIGIT8 = [3, 1, 3, 1, 3, 1, 3].freeze
+      private_constant :EAN_CHECK_DIGIT8
+
       EAN_CHECK_DIGIT13 = [1, 3, 1, 3, 1, 3, 1, 3, 1, 3, 1, 3].freeze
+      private_constant :EAN_CHECK_DIGIT13
 
       def rut_verificator_digit(rut)
         total = rut.to_s.rjust(8, '0').chars.zip(%w[3 2 7 6 5 4 3 2]).collect { |a, b| a.to_i * b.to_i }.inject(:+)

lib/faker/default/driving_licence.rb

@@ -104,7 +104,7 @@ def gb_licence_year(dob, gender)
           end
           g.computed do
             gender_marker = gender == :female ? 50 : 0
-            format('%02d', (dob.month + gender_marker))
+            format('%02d', dob.month + gender_marker)
           end
           g.computed do
             format('%02d', dob.day)

lib/faker/default/internet.rb

@@ -267,7 +267,7 @@ def domain_suffix(safe: nil)
       #   Faker::Internet.mac_address(prefix: 'aa:44')  #=> "aa:44:30:88:6e:95"
       def mac_address(prefix: '')
         prefix_digits = prefix.split(':').map { |d| d.to_i(16) }
-        address_digits = Array.new((6 - prefix_digits.size)) { rand(256) }
+        address_digits = Array.new(6 - prefix_digits.size) { rand(256) }
         (prefix_digits + address_digits).map { |d| format('%02x', d) }.join(':')
       end
 

lib/faker/default/placeholdit.rb

@@ -45,7 +45,7 @@ def image(size: '300x300', format: 'png', background_color: nil, text_color: nil
       private
 
       def generate_color
-        format('%06x', (rand * 0xffffff))
+        format('%06x', rand * 0xffffff)
       end
     end
   end

test/faker/books/test_lovecraft.rb

@@ -48,9 +48,9 @@ def test_range_count_param
     ss = @tester.sentences(number: 2..5)
     ps = @tester.paragraphs(number: 2..5)
 
-    assert(ws.length >= 2 && ws.length <= 5)
-    assert(ss.length >= 2 && ss.length <= 5)
-    assert(ps.length >= 2 && ps.length <= 5)
+    assert(ws.length.between?(2, 5))
+    assert(ss.length.between?(2, 5))
+    assert(ps.length.between?(2, 5))
   end
 
   def test_array_count_param
@@ -69,7 +69,7 @@ def test_words_with_large_count_params
     array = @tester.words(number: [250, 500])
 
     assert_equal(500, exact.length)
-    assert(range.length >= 250 && range.length <= 500)
+    assert(range.length.between?(250, 500))
     assert(array.length == 250 || array.length == 500)
   end
 

test/faker/default/test_array_sample_method_compat.rb

@@ -39,20 +39,20 @@ def test_returns_an_array_with_integer_param
 
     assert_kind_of Array, result
     assert_equal(2, result.length)
-    assert_empty((result - source))
+    assert_empty(result - source)
   end
 
   def test_returns_source_array_with_integer_param_equal_or_bigger_than_source_length
     source = %w[foo bar]
     result = source.sample(2)
 
     assert_kind_of Array, result
-    assert_predicate((source.sort <=> result.sort), :zero?)
+    assert_predicate(source.sort <=> result.sort, :zero?)
 
     result = source.sample(3)
 
     assert_kind_of Array, result
-    assert_predicate((source.sort <=> result.sort), :zero?)
+    assert_predicate(source.sort <=> result.sort, :zero?)
   end
 
   def test_raises_argument_error_with_negative_param

test/faker/default/test_faker_company.rb

@@ -77,7 +77,7 @@ def test_australian_business_number
     checksum = abn_checksum(abn)
 
     assert_match(/\d{11}/, abn)
-    assert_predicate((checksum % 89), :zero?)
+    assert_predicate(checksum % 89, :zero?)
   end
 
   def test_profession
@@ -167,8 +167,8 @@ def test_luhn_algorithm
 
     even_control = "#{even_base}#{even_luhn_complement}"
 
-    assert_predicate((luhn_checksum(odd_control) % 10), :zero?)
-    assert_predicate((luhn_checksum(even_control) % 10), :zero?)
+    assert_predicate(luhn_checksum(odd_control) % 10, :zero?)
+    assert_predicate(luhn_checksum(even_control) % 10, :zero?)
   end
 
   def test_brazilian_company_number
@@ -218,7 +218,7 @@ def test_russian_tax_number_checksum
     number = base_number[0..-2]
     checksum = base_number.chars.last.to_i
 
-    assert_predicate((inn_checksum(number) - checksum), :zero?)
+    assert_predicate(inn_checksum(number) - checksum, :zero?)
   end
 
   def test_sic_code