Commit 2f8b18b
authored
deps: bump Minitest version to
[minitest 5.26.0] introduced this change
minitest/minitest@68b3d0c,
and when dependabot tried to bump faker's version to 5.26.0 and we started getting this error:
```
Failure: test_faker_i18n(TestI18nLoad)
/home/runner/work/faker/faker/test/test_i18n_reload.rb:40:in `test_faker_i18n'
37: cmd = %( ruby -e "#{code}" )
38: output, status = Open3.capture2e(cmd)
39:
=> 40: assert_equal 0, status, output
41: end
42: end
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/runtime.rb:304:in `check_for_activated_spec!': You have already activated minitest 5.26.1, but your Gemfile requires minitest 5.25.5. Prepending `bundle exec` to your command may solve this. (Gem::LoadError)
from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/runtime.rb:25:in `block in setup'
from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/spec_set.rb:165:in `each'
from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/spec_set.rb:165:in `each'
from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/runtime.rb:24:in `map'
from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/runtime.rb:24:in `setup'
from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/inline.rb:66:in `block (2 levels) in gemfile'
from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/settings.rb:142:in `temporary'
from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/inline.rb:51:in `block in gemfile'
from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler.rb:403:in `block in with_unbundled_env'
from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler.rb:649:in `with_env'
from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler.rb:403:in `with_unbundled_env'
from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/inline.rb:42:in `gemfile'
from -e:3:in `<main>'
<0> expected but was
<#<Process::Status: pid 2343 exit 1>>
Error: /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/runtime.rb:304:in `check_for_activated_spec!': You have already activated minitest 5.26.1, but your Gemfile requires minitest 5.25.5. Prepending `bundle exec` to your command may solve this. (Gem::LoadError)
```
I can't quite say why removing the version definition fixes this but
it seems to reuse the version we have set in the Gemfile, and the tests pass.v5.26.1 and fix issues (#3144)1 parent 3de3f9c commit 2f8b18b
3 files changed
+4
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
0 commit comments