Skip to content

Commit 2f8b18b

Browse files
deps: bump Minitest version to v5.26.1 and fix issues (#3144)
[minitest 5.26.0] introduced this change minitest/minitest@68b3d0c, and when dependabot tried to bump faker's version to 5.26.0 and we started getting this error: ``` Failure: test_faker_i18n(TestI18nLoad) /home/runner/work/faker/faker/test/test_i18n_reload.rb:40:in `test_faker_i18n' 37: cmd = %( ruby -e "#{code}" ) 38: output, status = Open3.capture2e(cmd) 39: => 40: assert_equal 0, status, output 41: end 42: end /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/runtime.rb:304:in `check_for_activated_spec!': You have already activated minitest 5.26.1, but your Gemfile requires minitest 5.25.5. Prepending `bundle exec` to your command may solve this. (Gem::LoadError) from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/runtime.rb:25:in `block in setup' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/spec_set.rb:165:in `each' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/spec_set.rb:165:in `each' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/runtime.rb:24:in `map' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/runtime.rb:24:in `setup' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/inline.rb:66:in `block (2 levels) in gemfile' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/settings.rb:142:in `temporary' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/inline.rb:51:in `block in gemfile' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler.rb:403:in `block in with_unbundled_env' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler.rb:649:in `with_env' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler.rb:403:in `with_unbundled_env' from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/inline.rb:42:in `gemfile' from -e:3:in `<main>' <0> expected but was <#<Process::Status: pid 2343 exit 1>> Error: /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/gems/3.0.0/gems/bundler-2.4.22/lib/bundler/runtime.rb:304:in `check_for_activated_spec!': You have already activated minitest 5.26.1, but your Gemfile requires minitest 5.25.5. Prepending `bundle exec` to your command may solve this. (Gem::LoadError) ``` I can't quite say why removing the version definition fixes this but it seems to reuse the version we have set in the Gemfile, and the tests pass.
1 parent 3de3f9c commit 2f8b18b

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ source 'https://rubygems.org'
66
gemspec
77

88
gem 'benchmark'
9-
gem 'minitest', '5.25.5'
9+
gem 'minitest', '5.26.1'
1010
gem 'pry', '0.15.2'
1111
gem 'rake', '13.3.1'
1212
gem 'rubocop', '1.81.7'

Gemfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ GEM
1818
language_server-protocol (3.17.0.5)
1919
lint_roller (1.1.0)
2020
method_source (1.1.0)
21-
minitest (5.25.5)
21+
minitest (5.26.1)
2222
parallel (1.27.0)
2323
parser (3.3.10.0)
2424
ast (~> 2.4.1)
@@ -75,7 +75,7 @@ PLATFORMS
7575
DEPENDENCIES
7676
benchmark
7777
faker!
78-
minitest (= 5.25.5)
78+
minitest (= 5.26.1)
7979
pry (= 0.15.2)
8080
rake (= 13.3.1)
8181
rubocop (= 1.81.7)

test/test_i18n_reload.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ def test_faker_i18n
1212
1313
gemfile do
1414
source 'https://rubygems.org'
15-
gem 'minitest', '5.25.5'
15+
gem 'minitest'
1616
gem 'i18n'
1717
end
1818

0 commit comments

Comments
 (0)