Bump rubocop from 1.57.2 to 1.58.0 (#2864)

* Bump rubocop from 1.57.2 to 1.58.0

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.57.2 to 1.58.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.57.2...v1.58.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Rubocop fixes

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Author: sbs-cats

Gemfile

@@ -9,7 +9,7 @@ gem 'benchmark'
 gem 'minitest', '5.20.0'
 gem 'pry', '0.14.2'
 gem 'rake', '13.1.0'
-gem 'rubocop', '1.57.2'
+gem 'rubocop', '1.58.0'
 gem 'rubocop-minitest', '0.33.0'
 gem 'rubocop-rake', '0.6.0'
 gem 'simplecov', '0.22.0'

Gemfile.lock

@@ -14,7 +14,7 @@ GEM
     docile (1.4.0)
     i18n (1.14.1)
       concurrent-ruby (~> 1.0)
-    json (2.6.3)
+    json (2.7.0)
     language_server-protocol (3.17.0.3)
     method_source (1.0.0)
     minitest (5.20.0)
@@ -26,20 +26,20 @@ GEM
     pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    racc (1.7.1)
+    racc (1.7.3)
     rainbow (3.1.1)
     rake (13.1.0)
     regexp_parser (2.8.2)
     rexml (3.2.6)
-    rubocop (1.57.2)
+    rubocop (1.58.0)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.2.2.4)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.28.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.30.0)
@@ -70,7 +70,7 @@ DEPENDENCIES
   minitest (= 5.20.0)
   pry (= 0.14.2)
   rake (= 13.1.0)
-  rubocop (= 1.57.2)
+  rubocop (= 1.58.0)
   rubocop-minitest (= 0.33.0)
   rubocop-rake (= 0.6.0)
   simplecov (= 0.22.0)

lib/faker/default/json.rb

@@ -71,7 +71,7 @@ def add_depth_to_json(json: shallow_json, width: 3, options: { key: 'Name.first_
         options[:value] = "Faker::#{options[:value]}"
 
         hash = JSON.parse(json)
-        hash.each do |key, _|
+        hash.each_key do |key|
           add_hash_to_bottom(hash, [key], width, options)
         end
         JSON.generate(hash)
@@ -93,7 +93,7 @@ def build_shallow_hash(width, options)
       def add_hash_to_bottom(hash, key_array, width, options)
         key_string = build_keys_from_array(key_array)
         if eval("hash#{key_string}").is_a?(::Hash)
-          eval("hash#{key_string}").each do |key, _|
+          eval("hash#{key_string}").each_key do |key|
             key_array << key
             add_hash_to_bottom(hash, key_array, width, options)
           end

test/faker/creature/test_faker_bird.rb

@@ -59,7 +59,8 @@ def test_common_name_with_bad_parameter
 
   def test_order_with_common_names
     entry = @tester.order_with_common_name
-    assert_includes(@common_order_map.keys, entry[:order].to_sym) && \
+
+    assert_includes(@common_order_map.keys, entry[:order].to_sym) &&
       assert_includes(@common_order_map[entry[:order]], entry[:common_name])
   end
 

test/faker/default/test_faker_number.rb

@@ -60,8 +60,8 @@ def test_even_distribution
       assert stats[num] += 1
     end
 
-    stats.each do |_k, v|
-      assert_in_delta 10.0, 100.0 * v / times, 2.0
+    stats.each_value do |value|
+      assert_in_delta 10.0, 100.0 * value / times, 2.0
     end
   end