Merge branch 'main' into sb-deprecate-twitter-generator

Author: stefannibrasil

Gemfile

@@ -6,13 +6,13 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'benchmark'
-gem 'minitest', '5.25.5'
+gem 'minitest', '5.26.1'
 gem 'pry', '0.15.2'
 gem 'rake', '13.3.1'
-gem 'rubocop', '1.75.4'
-gem 'rubocop-minitest', '0.38.1'
+gem 'rubocop', '1.81.7'
+gem 'rubocop-minitest', '0.38.2'
 gem 'rubocop-rake', '0.7.1'
 gem 'simplecov', '0.22.0'
-gem 'test-unit', '3.7.0'
+gem 'test-unit', '3.7.1'
 gem 'timecop', '0.9.10'
 gem 'yard', '0.9.37'

Gemfile.lock

@@ -14,39 +14,39 @@ GEM
     docile (1.4.1)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.12.2)
+    json (2.16.0)
     language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
     method_source (1.1.0)
-    minitest (5.25.5)
+    minitest (5.26.1)
     parallel (1.27.0)
-    parser (3.3.8.0)
+    parser (3.3.10.0)
       ast (~> 2.4.1)
       racc
-    power_assert (2.0.5)
-    prism (1.4.0)
+    power_assert (3.0.1)
+    prism (1.6.0)
     pry (0.15.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
     racc (1.8.1)
     rainbow (3.1.1)
     rake (13.3.1)
-    regexp_parser (2.10.0)
-    rubocop (1.75.4)
+    regexp_parser (2.11.3)
+    rubocop (1.81.7)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.44.0, < 2.0)
+      rubocop-ast (>= 1.47.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.45.1)
+    rubocop-ast (1.48.0)
       parser (>= 3.3.7.2)
       prism (~> 1.4)
-    rubocop-minitest (0.38.1)
+    rubocop-minitest (0.38.2)
       lint_roller (~> 1.1)
       rubocop (>= 1.75.0, < 2.0)
       rubocop-ast (>= 1.38.0, < 2.0)
@@ -58,14 +58,14 @@ GEM
       docile (~> 1.1)
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
-    simplecov-html (0.13.1)
+    simplecov-html (0.13.2)
     simplecov_json_formatter (0.1.4)
-    test-unit (3.7.0)
+    test-unit (3.7.1)
       power_assert
     timecop (0.9.10)
-    unicode-display_width (3.1.4)
-      unicode-emoji (~> 4.0, >= 4.0.4)
-    unicode-emoji (4.0.4)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.1.0)
     yard (0.9.37)
 
 PLATFORMS
@@ -75,14 +75,14 @@ PLATFORMS
 DEPENDENCIES
   benchmark
   faker!
-  minitest (= 5.25.5)
+  minitest (= 5.26.1)
   pry (= 0.15.2)
   rake (= 13.3.1)
-  rubocop (= 1.75.4)
-  rubocop-minitest (= 0.38.1)
+  rubocop (= 1.81.7)
+  rubocop-minitest (= 0.38.2)
   rubocop-rake (= 0.7.1)
   simplecov (= 0.22.0)
-  test-unit (= 3.7.0)
+  test-unit (= 3.7.1)
   timecop (= 0.9.10)
   yard (= 0.9.37)
 

README.md

@@ -215,7 +215,6 @@ gem 'faker', :git => 'https://github.com/faker-ruby/faker.git', :branch => 'main
   - [Faker::Beer](doc/default/beer.md)
   - [Faker::Blood](doc/default/blood.md)
   - [Faker::Boolean](doc/default/boolean.md)
-  - [Faker::BossaNova](doc/default/bossa_nova.md)
   - [Faker::Business](doc/default/business.md)
   - [Faker::Camera](doc/default/camera.md)
   - [Faker::Cannabis](doc/default/cannabis.md)
@@ -421,6 +420,7 @@ gem 'faker', :git => 'https://github.com/faker-ruby/faker.git', :branch => 'main
   - [Faker::Music::Rush](doc/music/rush.md)
   - [Faker::Music::SmashingPumpkins](doc/music/smashing_pumpkins.md)
   - [Faker::Music::UmphreysMcgee](doc/music/umphreys_mcgee.md)
+  - [Faker::Music::BossaNova](doc/music/bossa_nova.md)
 </details>
 
 <details>

doc/default/bossa_nova.md

@@ -50,3 +50,24 @@ Faker::IdNumber.danish_id_number(gender: :female) #=> "050390-9980"
 # Generate a valid French Social Security number (INSEE number)
 Faker::IdNumber.french_insee_number #=> "22510589696868"
 ```
+
+## ID Number and Locales
+
+Besides the default ID numbers, faker supports localized `.valid` and `.invalid` values:
+
+```ruby
+Faker::Config.locale = 'fr-FR'
+Faker::IdNumber.valid #=> "22510589696868"
+```
+
+Locales with specific intricacies are as such:
+
+### en-GB
+
+When the locale is set to British English, unformatted [National Insurance](https://www.gov.uk/national-insurance/your-national-insurance-number) numbers are generated:
+
+```ruby
+Faker::Config.locale = 'en-GB'
+Faker::IdNumber.valid #=> "AJ405924A"
+Faker::IdNumber.invalid #=> "BG316764W"
+

doc/default/id_number.md

@@ -0,0 +1,7 @@
+# Faker::Music::BossaNova
+
+```ruby
+Faker::Music::BossaNova.artist #=> "Tom Jobim"
+
+Faker::Music::BossaNova.song #=> "Chega de Saudade"
+```

doc/music/bossa_nova.md

@@ -240,7 +240,7 @@ def paragraph_by_chars(characters: 256)
 
           paragraph += " #{paragraph(sentence_count: 3)}" while paragraph.length < characters
 
-          "#{paragraph[0...characters - 1]}."
+          "#{paragraph[0...(characters - 1)]}."
         end
       end
     end

lib/faker/books/lovecraft.rb

@@ -15,7 +15,8 @@ class << self
       #   Faker::Boolean.boolean(true_ratio: 0.2) #=> false
       #
       # @faker.version 1.6.2
-      def boolean(true_ratio: 0.5)
+      #
+      def boolean(true_ratio: 0.5) # rubocop:disable Naming/PredicateMethod
         (rand < true_ratio)
       end
     end

lib/faker/default/boolean.rb

@@ -591,7 +591,7 @@ def collect_regon_sum(array)
 
       def weight_sum(array, weights)
         sum = 0
-        (0..weights.size - 1).each do |index|
+        (0..(weights.size - 1)).each do |index|
           sum += (array[index] * weights[index])
         end
         sum