Skip to content

Commit e15e606

Browse files
authored
Move en-US.yml's cell_phone entry to the correct position (#2924)
`PhoneNumber.cell_phone` expects an i18n key of `cell_phone.formats`, but the en-US.yml file currently has `faker.phone_number.cell_phone` instead of `faker.cell_phone`. The result of that mismatch is that `cell_phone` will ignore the defined formats, and potentially generate invalid US numbers (e.g. those with an area code beginning with 1) when the locale is en-US. 31d99d1 reworked YAML structure and appears to have inadvertently moved the key. You can see the change in US number behavior in a console: Faker::Config.locale = "en-US" Faker::PhoneNumber.translate("faker.cell_phone.formats") On 3.3.0 this returns ["###-###-####", "(###) ###-####", "###.###.####", "### ### ####"] because it's the fallback value within the `en` (not `en-US`) locale file. The correct value should be the formats outdented in this commit.
1 parent 3c85321 commit e15e606

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

lib/locales/en-US.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6949,16 +6949,16 @@ en-US:
69496949
- "(#{PhoneNumber.area_code}) #{PhoneNumber.exchange_code}-#{PhoneNumber.subscriber_number} x#{PhoneNumber.extension}"
69506950
- "#{PhoneNumber.area_code}-#{PhoneNumber.exchange_code}-#{PhoneNumber.subscriber_number} x#{PhoneNumber.extension}"
69516951
- "#{PhoneNumber.area_code}.#{PhoneNumber.exchange_code}.#{PhoneNumber.subscriber_number} x#{PhoneNumber.extension}"
6952-
cell_phone:
6953-
formats:
6954-
- "#{PhoneNumber.area_code}-#{PhoneNumber.exchange_code}-#{PhoneNumber.subscriber_number}"
6955-
- "(#{PhoneNumber.area_code}) #{PhoneNumber.exchange_code}-#{PhoneNumber.subscriber_number}"
6956-
- "#{PhoneNumber.area_code}-#{PhoneNumber.exchange_code}-#{PhoneNumber.subscriber_number}"
6957-
- "#{PhoneNumber.area_code}.#{PhoneNumber.exchange_code}.#{PhoneNumber.subscriber_number}"
6958-
- "#{PhoneNumber.area_code}-#{PhoneNumber.exchange_code}-#{PhoneNumber.subscriber_number}"
6959-
- "(#{PhoneNumber.area_code}) #{PhoneNumber.exchange_code}-#{PhoneNumber.subscriber_number}"
6960-
- "#{PhoneNumber.area_code}-#{PhoneNumber.exchange_code}-#{PhoneNumber.subscriber_number}"
6961-
- "#{PhoneNumber.area_code}.#{PhoneNumber.exchange_code}.#{PhoneNumber.subscriber_number}"
6952+
cell_phone:
6953+
formats:
6954+
- "#{PhoneNumber.area_code}-#{PhoneNumber.exchange_code}-#{PhoneNumber.subscriber_number}"
6955+
- "(#{PhoneNumber.area_code}) #{PhoneNumber.exchange_code}-#{PhoneNumber.subscriber_number}"
6956+
- "#{PhoneNumber.area_code}-#{PhoneNumber.exchange_code}-#{PhoneNumber.subscriber_number}"
6957+
- "#{PhoneNumber.area_code}.#{PhoneNumber.exchange_code}.#{PhoneNumber.subscriber_number}"
6958+
- "#{PhoneNumber.area_code}-#{PhoneNumber.exchange_code}-#{PhoneNumber.subscriber_number}"
6959+
- "(#{PhoneNumber.area_code}) #{PhoneNumber.exchange_code}-#{PhoneNumber.subscriber_number}"
6960+
- "#{PhoneNumber.area_code}-#{PhoneNumber.exchange_code}-#{PhoneNumber.subscriber_number}"
6961+
- "#{PhoneNumber.area_code}.#{PhoneNumber.exchange_code}.#{PhoneNumber.subscriber_number}"
69626962
id_number:
69636963
valid: "#{IdNumber.ssn_valid}"
69646964
invalid:

0 commit comments

Comments
 (0)