Merge branch 'main' into feature/extend-arabic-locales

Author: ramzieus

Gemfile

@@ -8,11 +8,11 @@ gemspec
 gem 'benchmark'
 gem 'minitest', '5.25.5'
 gem 'pry', '0.15.2'
-gem 'rake', '13.3.0'
+gem 'rake', '13.3.1'
 gem 'rubocop', '1.75.4'
 gem 'rubocop-minitest', '0.38.1'
 gem 'rubocop-rake', '0.7.1'
 gem 'simplecov', '0.22.0'
-gem 'test-unit', '3.6.9'
+gem 'test-unit', '3.7.0'
 gem 'timecop', '0.9.10'
 gem 'yard', '0.9.37'

Gemfile.lock

@@ -8,7 +8,7 @@ GEM
   remote: https://rubygems.org/
   specs:
     ast (2.4.3)
-    benchmark (0.4.1)
+    benchmark (0.5.0)
     coderay (1.1.3)
     concurrent-ruby (1.3.5)
     docile (1.4.1)
@@ -30,7 +30,7 @@ GEM
       method_source (~> 1.0)
     racc (1.8.1)
     rainbow (3.1.1)
-    rake (13.3.0)
+    rake (13.3.1)
     regexp_parser (2.10.0)
     rubocop (1.75.4)
       json (~> 2.3)
@@ -60,7 +60,7 @@ GEM
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.13.1)
     simplecov_json_formatter (0.1.4)
-    test-unit (3.6.9)
+    test-unit (3.7.0)
       power_assert
     timecop (0.9.10)
     unicode-display_width (3.1.4)
@@ -77,12 +77,12 @@ DEPENDENCIES
   faker!
   minitest (= 5.25.5)
   pry (= 0.15.2)
-  rake (= 13.3.0)
+  rake (= 13.3.1)
   rubocop (= 1.75.4)
   rubocop-minitest (= 0.38.1)
   rubocop-rake (= 0.7.1)
   simplecov (= 0.22.0)
-  test-unit (= 3.6.9)
+  test-unit (= 3.7.0)
   timecop (= 0.9.10)
   yard (= 0.9.37)
 

lib/faker/default/bank.rb

@@ -17,11 +17,7 @@ class << self
       #
       # @faker.version 1.9.1
       def account_number(digits: 10)
-        output = ''
-
-        output += rand.to_s[2..] while output.length < digits
-
-        output[0...digits]
+        Array.new(digits) { rand(10) }.join
       end
 
       ##

lib/locales/en/hobby.yml

@@ -3,7 +3,6 @@ en:
     hobby:
       activity:
         - 3D printing
-        - amateur radio
         - scrapbook
         - Amateur radio
         - Acting

lib/locales/en/overwatch.yml

@@ -865,7 +865,7 @@ en:
           - good morning
           - Happy birthday
           - Have a nice day
-          - Its the little things
+          - It's the little things
           - Kaboom!
           - Shiny
           - Smile!

lib/locales/en/rajnikanth.yml

@@ -58,7 +58,7 @@ en:
         "When RAJNI had surgery, the anesthesia was applied to the doctors.",
         "The apple which fell on newton was actually thrown by Rajinikanth.",
         "Only Rajinijanth has 32 wisdom teeth.",
-        "When Rajinikanth goes thru immigration.. the officers show him thier passports.",
+        "When Rajinikanth goes thru immigration... the officers show him their passports.",
         "Sun doesn't rise until Rajinikanth says 'Good Morning'",
         "Once Rajnikant, after chewing the 'PAAN', spit on the wall of a building.",
         "Today that building is popularly known as THE RED FORT..",

lib/locales/en/street_fighter.yml

@@ -207,7 +207,7 @@ en:
           - My psycho power feeds on hatred and death!
           - I demand an opponent worthy of my strength!
           - When I control the planet, I shall purge it of all hope!
-          - Anyone who defies me willingly invites thier own death!
+          - Anyone who defies me willingly invites their own death!
           - Close your eyes! An endless nightmare awaits!
           - Embrace your fear as you are enveloped by an eternal nightmare!
           - Kneel before me or die beneath my heal. The choice is yours to make freely!

lib/locales/ja/artist.yml

@@ -0,0 +1,46 @@
+ja:
+  faker:
+    artist:
+      names:
+        - "ドナテロ"
+        - "ボッティチェッリ"
+        - "ミケランジェロ"
+        - "ラファエロ"
+        - "ティツィアーノ"
+        - "デューラー"
+        - "カラヴァッジョ"
+        - "ルーベンス"
+        - "ベルニーニ"
+        - "レンブラント"
+        - "ピサロ"
+        - "マネ"
+        - "ドガ"
+        - "セザンヌ"
+        - "モネ"
+        - "ルノワール"
+        - "カサット"
+        - "ゴーギャン"
+        - "ムンク"
+        - "クリムト"
+        - "マティス"
+        - "ピカソ"
+        - "カンディンスキー"
+        - "シャガール"
+        - "スーラ"
+        - "マグリット"
+        - "エッシャー"
+        - "ロスコ"
+        - "ダリ"
+        - "カーロ"
+        - "ポロック"
+        - "ウォーホル"
+        - "ヴェトリアーノ"
+        - "ダ・ヴィンチ"
+        - "エル・グレコ"
+        - "ウィンスロー・ホーマー"
+        - "パウル・クレー"
+        - "エドワード・ホッパー"
+        - "ディエゴ・リベラ"
+        - "フィンセント・ファン・ゴッホ"
+        - "ジョアン・ミロ"
+        - "アンセル・アダムス"

test/faker/default/test_faker_id_number.rb

@@ -66,7 +66,7 @@ def test_invalid_south_african_id_number
     sample = @tester.invalid_south_african_id_number
 
     assert_raises Date::Error do
-      Date.parse(south_african_id_number_to_date_of_birth_string(sample))
+      Date.parse(sample[0..5])
     end
   end
 
@@ -276,15 +276,12 @@ def test_danish_id_number_invalid_gender
 
   private
 
-  def south_african_id_number_to_date_of_birth_string(sample)
-    "19#{sample[0..1]}/#{sample[2..3]}/#{sample[4..5]}}"
-  end
-
   def assert_valid_south_african_id_number(sample)
     assert_equal 13, sample.length
     assert_match(/^\d{13}$/, sample)
     assert_include Faker::IdNumber::ZA_CITIZENSHIP_DIGITS, sample[10]
     assert_equal Faker::IdNumber::ZA_RACE_DIGIT, sample[11]
-    assert Date.parse(south_african_id_number_to_date_of_birth_string(sample))
+
+    assert Date.parse(sample[0..5])
   end
 end

test/test_ja_locale.rb

@@ -42,6 +42,11 @@ def test_ja_ancient_methods
     assert_not_english(Faker::Ancient.god)
   end
 
+  def test_ja_artist_method
+    assert_kind_of String, Faker::Artist.name
+    assert_not_english(Faker::Artist.name)
+  end
+
   def test_ja_cat_methods
     assert_kind_of String, Faker::Creature::Cat.breed
     assert_not_match(/[a-zA-Z]/, Faker::Creature::Cat.breed)