Improved Core Infrastructure: resilient Kafka, cleaner background workers, and API versioning (#61)

* Applied version to endpoints

* Fixture for domain objects

* Refactored Kafka consumer to ensure topic creation

* Updated Kiota clients with the latest API definitions

* Ensured release build to github actions

Author: falberthen

.github/workflows/ecommerceddd-build.yml

@@ -11,28 +11,34 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
-    - name: Setup .NET
-      uses: actions/setup-dotnet@v1
-      with:
-        dotnet-version: 8.0.x
-    - name: Restore dependencies
-      run: dotnet restore EcommerceDDD.sln
-    - name: Build
-      run: dotnet build --no-restore EcommerceDDD.sln
-    - name: Test
-      run: dotnet test --no-build --verbosity normal EcommerceDDD.sln
+      - uses: actions/checkout@v2
+
+      - name: Setup .NET
+        uses: actions/setup-dotnet@v1
+        with:
+          dotnet-version: 8.0.x
+
+      - name: Restore dependencies
+        run: dotnet restore EcommerceDDD.sln
+
+      - name: Build (Release)
+        run: dotnet build --no-restore -c Release EcommerceDDD.sln
+
+      - name: Test (Release)
+        run: dotnet test --no-build --verbosity normal -c Release EcommerceDDD.sln
 
   spa-test-verify:
     runs-on: ubuntu-latest
     defaults:
       run:
         working-directory: src/EcommerceDDD.Spa
+
     steps:
       - uses: actions/checkout@v4
+
       - uses: actions/setup-node@v4
         with:
           node-version: 18
+
       - run: npm ci
       - run: npm run test
-   

docker-compose.yml

@@ -46,7 +46,7 @@ services:
       interval: 10s
       timeout: 5s
       retries: 5
-      start_period: 30s
+      start_period: 20s
     networks:
       - ecommercedddnet
     ports:
@@ -59,31 +59,13 @@ services:
       KAFKA_ADVERTISED_LISTENERS: 'PLAINTEXT://kafka:29092,PLAINTEXT_HOST://kafka:9092'
       KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR: 1
       KAFKA_GROUP_INITIAL_REBALANCE_DELAY_MS: 0
+      KAFKA_AUTO_CREATE_TOPICS_ENABLE: 'true'
     restart: 
       on-failure
     depends_on:      
       zookeeper:
         condition: service_started   
 
-  init-kafka:
-    image: confluentinc/cp-kafka:latest  
-    entrypoint: [ '/bin/sh', '-c' ]
-    networks:
-      - ecommercedddnet
-    environment:
-      KAFKA_CLUSTERS_0_NAME: local
-      KAFKA_CLUSTERS_0_BOOTSTRAPSERVERS: 'kafka:29092'
-    command: >
-      /bin/sh -c "sleep 10 &&
-        kafka-topics --bootstrap-server kafka:29092 --create --if-not-exists --topic Orders --replication-factor 1 --partitions 1 &&
-        kafka-topics --bootstrap-server kafka:29092 --create --if-not-exists --topic Payments --replication-factor 1 --partitions 1 &&
-        kafka-topics --bootstrap-server kafka:29092 --create --if-not-exists --topic Shipments --replication-factor 1 --partitions 1"
-    restart: 
-      on-failure
-    depends_on:      
-      kafka:
-        condition: service_started
-
   kafka_topics_ui:
     image: provectuslabs/kafka-ui:latest
     hostname: kafka-ui
@@ -349,7 +331,7 @@ services:
       postgres:
         condition: service_healthy      
       kafka:
-        condition: service_healthy
+        condition: service_healthy      
       ecommerceddd-products:
         condition: service_started
       connect:

src/Core/EcommerceDDD.Core.Infrastructure/EcommerceDDD.Core.Infrastructure.csproj

@@ -30,6 +30,7 @@
 		<PackageReference Include="Scrutor" Version="6.0.1" />
 		<PackageReference Include="Swashbuckle.AspNetCore.SwaggerGen" Version="8.1.1" />
 		<PackageReference Include="Swashbuckle.AspNetCore.SwaggerUI" Version="8.1.1" />
+		<PackageReference Include="Microsoft.AspNetCore.Mvc.Versioning" Version="5.1.0" />
 	</ItemGroup>
 
 	<ItemGroup>

src/Core/EcommerceDDD.Core.Infrastructure/GlobalUsings.cs

@@ -1,4 +1,5 @@
 global using Confluent.Kafka;
+global using Duende.IdentityModel;
 global using Duende.IdentityModel.Client;
 global using EcommerceDDD.Core.CQRS.CommandHandling;
 global using EcommerceDDD.Core.CQRS.QueryHandling;
@@ -14,10 +15,12 @@
 global using EcommerceDDD.Core.Infrastructure.Kafka.Serialization;
 global using EcommerceDDD.Core.Infrastructure.Kafka.Workers;
 global using EcommerceDDD.Core.Infrastructure.Marten;
+global using EcommerceDDD.Core.Infrastructure.Outbox;
 global using EcommerceDDD.Core.Infrastructure.Outbox.Workers;
 global using EcommerceDDD.Core.Infrastructure.WebApi;
 global using EcommerceDDD.Core.Infrastructure.Workers;
 global using EcommerceDDD.Core.Persistence;
+global using EcommerceDDD.Core.Reflection;
 global using EcommerceDDD.Core.Testing;
 global using Marten;
 global using Microsoft.AspNetCore.Authentication;
@@ -38,11 +41,11 @@
 global using Newtonsoft.Json;
 global using Newtonsoft.Json.Linq;
 global using Polly;
+global using System.Diagnostics;
 global using System.IdentityModel.Tokens.Jwt;
 global using System.Net.Http.Headers;
 global using System.Net.Mime;
 global using System.Reflection;
+global using System.Security.Claims;
 global using System.Text;
 global using Weasel.Core;
-global using Duende.IdentityModel;
-global using System.Security.Claims;

src/Core/EcommerceDDD.Core.Infrastructure/Identity/AuthPolicyBuilder.cs

@@ -2,12 +2,6 @@
 
 public static class AuthPolicyBuilder
 {
-    public static AuthorizationPolicy M2MAccess =>
-        new AuthorizationPolicyBuilder()
-            .RequireAuthenticatedUser()
-            .RequireClaim("scope", "ecommerceddd-api.scope")
-            .Build();
-
     public static AuthorizationPolicy CanRead =>
         new AuthorizationPolicyBuilder()
             .RequireAuthenticatedUser()
@@ -25,4 +19,4 @@ public static class AuthPolicyBuilder
             .RequireAuthenticatedUser()
             .RequireClaim("scope", "delete")
             .Build();
-}
+}