feat: remove custom env var validation for s3 driver

Author: Makeshift

docker-compose.yml

@@ -1,5 +1,3 @@
-version: '3.9'
-
 services:
   postgres:
     image: postgres:15
@@ -24,3 +22,25 @@ services:
     command: -c 'mkdir -p /data/test && /usr/bin/minio server /data'
     ports:
       - 9000:9000
+    environment:
+      MINIO_ROOT_USER: access_key
+      MINIO_ROOT_PASSWORD: secret_key
+
+  cache-server:
+    build:
+      dockerfile: Dockerfile
+      context: .
+    ports:
+      - '3000:3000'
+    depends_on:
+      - minio
+
+    environment:
+      API_BASE_URL: http://localhost:3000
+
+      STORAGE_DRIVER: s3
+      STORAGE_S3_BUCKET: test
+
+      AWS_ACCESS_KEY_ID: access_key
+      AWS_SECRET_ACCESS_KEY: secret_key
+      AWS_ENDPOINT_URL: http://minio:9000

docs/content/2.storage-drivers/s3.md

@@ -24,12 +24,10 @@ services:
 
       STORAGE_DRIVER: s3
       STORAGE_S3_BUCKET: gh-actions-cache
-      STORAGE_S3_ACCESS_KEY: access_key
-      STORAGE_S3_SECRET_KEY: secret_key
 
-      STORAGE_S3_ENDPOINT: minio
-      STORAGE_S3_PORT: '9000'
-      STORAGE_S3_USE_SSL: 'false'
+      AWS_ACCESS_KEY_ID: access_key
+      AWS_SECRET_ACCESS_KEY: secret_key
+      AWS_ENDPOINT_URL: http://minio:9000
     volumes:
       - cache-data:/app/.data
 
@@ -47,6 +45,8 @@ volumes:
 
 ### `docker-compose` AWS S3 example
 
+This example assumes that credentials are being provided by the environment, e.g. via an [instance profile](https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_use_switch-role-ec2_instance-profiles.html) or [EKS IRSA](https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts.html).
+
 ```yaml [docker-compose.yml]
 version: '3.9'
 
@@ -70,30 +70,65 @@ volumes:
 
 ### Environment Variables
 
-Don't forget to set the `STORAGE_DRIVER` environment variable to `s3` to use the S3 storage driver.
+The only required S3-related environment variables are `STORAGE_DRIVER: s3` and `STORAGE_S3_BUCKET`. The rest of the environment variables are optional and depend on your S3-compatible storage provider.
+
+The AWS SDK will automatically use any AWS credentials available in the environment, e.g. `AWS_ACCESS_KEY_ID`, `AWS_SECRET_ACCESS_KEY` and `AWS_REGION`. Outside of AWS, these environment variables can still be used to authenticate with S3-compatible storage, as seen in the Minio example above.
 
-The AWS SDK will automatically use any AWS credentials available in the environment, e.g. `AWS_ACCESS_KEY_ID`, `AWS_SECRET_ACCESS_KEY` and `AWS_REGION`.
+Common environment variables are listed below. For a full list of configuration options, see the [AWS SDK documentation](https://docs.aws.amazon.com/sdkref/latest/guide/settings-reference.html#EVarSettings).
 
 #### `STORAGE_S3_BUCKET`
 
 Example: `gh-actions-cache`
 
-The name of the S3 bucket used for storage.
+The name of the S3 bucket used for storage. This environment variable is always required.
+
+#### `AWS_REGION`
+
+Example: `us-east-1`
+
+The AWS SDK relies on this variable being set. In the cache server, it defaults to `us-east-1` if not provided. This has no effect if you are using a non-AWS S3-compatible storage provider, such as MinIO.
+
+#### `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY`
+
+Example:
+  `AWS_ACCESS_KEY_ID: access_key`
+  `AWS_SECRET_ACCESS_KEY: secret_key`
 
-#### `STORAGE_S3_ENDPOINT`
+This is the access key/secret key used to authenticate with S3-compatible storage. If required to authenticate with your provider, these should be provided by the provider. Alternatively, you can use the `AWS_PROFILE` environment variable to specify a profile from your AWS credentials file.
 
-Example: `s3.amazonaws.com`, `minio`
+#### `AWS_PROFILE`
 
-The endpoint hostname for S3 storage.
+Example: `my-profile`
 
-#### `STORAGE_S3_PORT`
+If you wish to run the cache server locally and utilize a profile from your AWS credentials file or local AWS CLI configuration, you can set the `AWS_PROFILE` environment variable to the name of the profile. Note that this will also require mounting the AWS credentials file into the container in order for the SDK to be able to find it.
 
-Example: `443`, `9000`
+```yaml [docker-compose.yml]
+version: '3.9'
 
-The port S3 storage is running on.
+services:
+  cache-server:
+    image: ghcr.io/falcondev-oss/github-actions-cache-server:latest
+    ports:
+      - '3000:3000'
+    environment:
+      API_BASE_URL: http://localhost:3000
+
+      STORAGE_DRIVER: s3
+      STORAGE_S3_BUCKET: gh-actions-cache
+
+      AWS_PROFILE: my-profile
+
+    volumes:
+      - cache-data:/app/.data
+      # Mount the AWS CLI credentials and config into the container
+      - ~/.aws:/root/.aws:ro
+
+volumes:
+  cache-data:
+```
 
-#### `STORAGE_S3_USE_SSL`
+#### `AWS_ENDPOINT_URL`
 
-Example: `false`
+Example: `http://minio:9000`
 
-Whether to use SSL for S3 storage connections.
+This is the endpoint URL for the S3-compatible storage. This is only required if you are using a non-AWS S3-compatible storage provider, such as MinIO.

lib/storage/drivers/s3.ts

@@ -17,37 +17,13 @@ import { streamToBuffer } from '~/lib/utils'
 export const s3Driver = defineStorageDriver({
   envSchema: z.object({
     STORAGE_S3_BUCKET: z.string().min(1),
-    STORAGE_S3_ENDPOINT: z.string().optional(),
-    STORAGE_S3_REGION: z.string().min(1).default('us-east-1'),
-    STORAGE_S3_PORT: z.coerce.number().positive().optional(),
-    STORAGE_S3_USE_SSL: z
-      .string()
-      .transform((v) => v === 'true')
-      .optional(),
-    STORAGE_S3_ACCESS_KEY: z.string().optional(),
-    STORAGE_S3_SECRET_KEY: z.string().optional(),
-    AWS_REGION: z.string().optional(),
-    AWS_DEFAULT_REGION: z.string().optional(),
+    // AWS SDK requires an AWS_REGION to be set, even if you're using a custom endpoint
+    AWS_REGION: z.string().default('us-east-1'),
   }),
   async setup(options) {
-    const protocol = options.STORAGE_S3_USE_SSL ? 'https' : 'http'
-    const port = options.STORAGE_S3_PORT ? `:${options.STORAGE_S3_PORT}` : ''
-    let credentials
-
-    if (options.STORAGE_S3_ACCESS_KEY && options.STORAGE_S3_SECRET_KEY) {
-      credentials = {
-        secretAccessKey: options.STORAGE_S3_SECRET_KEY,
-        accessKeyId: options.STORAGE_S3_ACCESS_KEY,
-      }
-    }
-
     const s3 = new S3Client({
-      credentials,
-      endpoint: options.STORAGE_S3_ENDPOINT
-        ? `${protocol}://${options.STORAGE_S3_ENDPOINT}${port}`
-        : undefined,
-      region: options.AWS_REGION ?? options.AWS_DEFAULT_REGION ?? options.STORAGE_S3_REGION,
       forcePathStyle: true,
+      region: options.AWS_REGION,
     })
 
     try {

nitro.config.ts

@@ -38,5 +38,4 @@ export default defineNitroConfig({
       exclude: ['../../docs'],
     },
   },
-  compatibilityDate: '2025-02-01',
 })