Add unstable feature checking capability to skip a test that would not be supported

Author: jason-famedly

client/client.go

@@ -520,6 +520,17 @@ func (c *CSAPI) GetDefaultRoomVersion(t ct.TestLike) gomatrixserverlib.RoomVersi
 	return gomatrixserverlib.RoomVersion(defaultVersion.Str)
 }
 
+// GetVersions queries the server's client versions
+func (c *CSAPI) GetVersions(t ct.TestLike) []byte {
+	t.Helper()
+	res := c.MustDo(t, "GET", []string{"_matrix", "client", "versions"})
+	body, err := io.ReadAll(res.Body)
+	if err != nil {
+		ct.Fatalf(t, "unable to read response body: %v", err)
+	}
+	return body
+}
+
 // MustUploadKeys uploads device and/or one time keys to the server, returning the current OTK counts.
 // Both device keys and one time keys are optional. Fails the test if the upload fails.
 func (c *CSAPI) MustUploadKeys(t ct.TestLike, deviceKeys map[string]interface{}, oneTimeKeys map[string]interface{}) (otkCounts map[string]int) {

tests/msc3911/cs_api_restricted_media_test.go

@@ -35,6 +35,9 @@ func TestRestrictedMediaUnstable(t *testing.T) {
 
 	alice.LoginUser(t, alice.UserID, "password")
 
+	// gjson look ups that have periods need to be escaped or it thinks it is a path to another object
+	SkipTestIfNotCapable(t, alice, `org\.matrix\.msc3911`)
+
 	// Let's give alice a profile avatar
 	aliceGlobalProfileAvatarMxcUri := alice.MustUploadContentRestricted(t, data.MatrixSvg, "alice_avatar.svg", "img/svg")
 	alice.MustSetProfileAvatar(t, aliceGlobalProfileAvatarMxcUri)

tests/msc3911/federation_restricted_media_test.go

@@ -44,6 +44,9 @@ func TestFederationRestrictedMediaUnstable(t *testing.T) {
 
 	alice.LoginUser(t, alice.UserID, "password")
 
+	// gjson look ups that have periods need to be escaped or it thinks it is a path to another object
+	SkipTestIfNotCapable(t, alice, `org\.matrix\.msc3911`)
+
 	// Let's give alice a profile avatar
 	aliceGlobalProfileAvatarMxcUri := alice.MustUploadContentRestricted(t, data.MatrixSvg, "alice_avatar.svg", "img/svg")
 	alice.MustSetProfileAvatar(t, aliceGlobalProfileAvatarMxcUri)

tests/msc3911/main_test.go

@@ -7,6 +7,7 @@ import (
 	"github.com/matrix-org/complement/b"
 	"github.com/matrix-org/complement/client"
 	"github.com/matrix-org/complement/internal/data"
+	"github.com/tidwall/gjson"
 )
 
 func TestMain(m *testing.M) {
@@ -68,3 +69,15 @@ func MustUploadMediaAttachToMembershipEventAndSendIntoRoom(t *testing.T, sending
 	event_id := sendingUser.SendEventWithAttachedMediaSynced(t, roomID, picture_message, mxcUri)
 	return mxcUri, event_id
 }
+
+// Check the server's client version endpoint for an unstable feature to be enabled. If it is not found, skip the test
+func SkipTestIfNotCapable(t *testing.T, client *client.CSAPI, feature string) {
+	versionsObject := client.GetVersions(t)
+	unstableFeatures := gjson.GetBytes(versionsObject, "unstable_features")
+
+	thingEnabled := unstableFeatures.Get(feature)
+	if thingEnabled.Type != gjson.True {
+		t.Skipf("%s not supported on this homeserver", feature)
+	}
+
+}