Skip to content

Client: getRoomById method name is misleading #2199

@Feichtmeier

Description

@Feichtmeier

Preflight Checklist

  • I could not find a solution in the existing issues, docs, nor discussions

Describe your problem

The Client class includes the getRoomById method to find a room with a roomId in both the rooms list and the archived rooms list.
This could be misleading because you need to check afterwards what the membership of this room is and it could happen that you find an archived room when you want to find it (or null) in the room list.

Describe your ideal solution

Add a required argument "membership" to filter or replace the current method with two new methods "getJoinedOrInvitedRoomById" and "getArchivedRoomByIdFromCache"

Version

4.0.0

Security requirements

No response

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions