Skip to content
This repository was archived by the owner on Feb 23, 2023. It is now read-only.

Commit 75abe74

Browse files
committed
Removed iOS hack related to input focus
+ fixed typo from the previous commit
1 parent c33194d commit 75abe74

File tree

8 files changed

+9
-64
lines changed

8 files changed

+9
-64
lines changed

dist/jquery.fancybox.css

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,6 @@ body.compensate-for-scrollbar {
44
.fancybox-active {
55
height: auto; }
66

7-
.fancybox-iosfix {
8-
height: 100%;
9-
left: 0;
10-
overflow: hidden;
11-
position: fixed;
12-
width: 100%; }
13-
147
.fancybox-is-hidden {
158
left: -9999px;
169
margin: 0;

dist/jquery.fancybox.js

Lines changed: 3 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// ==================================================
2-
// fancyBox v3.3.3
2+
// fancyBox v3.3.4
33
//
44
// Licensed GPLv3 for open source use
55
// or fancyBox Commercial License for commercial use
@@ -527,18 +527,6 @@
527527
$container,
528528
buttonStr;
529529

530-
// iOS hack; https://bugs.webkit.org/show_bug.cgi?id=176896
531-
if (
532-
firstItem.type !== "image" &&
533-
/iPad|iPhone|iPod/.test(navigator.userAgent) &&
534-
!window.MSStream &&
535-
!$("body").hasClass("fancybox-iosfix")
536-
) {
537-
$("body")
538-
.addClass("fancybox-iosfix")
539-
.css("top", -$W.scrollTop());
540-
}
541-
542530
// Hide scrollbars
543531
// ===============
544532

@@ -2638,14 +2626,6 @@
26382626
$body.removeClass("fancybox-active compensate-for-scrollbar");
26392627

26402628
$("#fancybox-style-noscroll").remove();
2641-
2642-
if ($body.hasClass("fancybox-iosfix")) {
2643-
scrollTop = parseInt($body[0].style.top, 10);
2644-
2645-
$body.css("top", "").removeClass("fancybox-iosfix");
2646-
2647-
$W.scrollTop(-scrollTop);
2648-
}
26492629
}
26502630
},
26512631

@@ -2765,7 +2745,7 @@
27652745
});
27662746

27672747
$.fancybox = {
2768-
version: "3.3.3",
2748+
version: "3.3.4",
27692749
defaults: defaults,
27702750

27712751
// Get current instance and execute a command.
@@ -3258,7 +3238,7 @@
32583238
return "&start=" + ((m ? parseInt(m, 10) * 60 : 0) + parseInt(s, 10));
32593239
});
32603240
} else if (providerName === "vimeo") {
3261-
c = url.replace("&%23", "#");
3241+
url = url.replace("&%23", "#");
32623242
}
32633243

32643244
return false;

dist/jquery.fancybox.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/jquery.fancybox.min.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@fancyapps/fancybox",
33
"description": "Touch enabled, responsive and fully customizable jQuery lightbox script",
4-
"version": "3.3.3",
4+
"version": "3.3.4",
55
"homepage": "http://fancyapps.com/fancybox/",
66
"main": "./dist/jquery.fancybox.js",
77
"author": "fancyApps",

src/css/core.css

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,6 @@ body.compensate-for-scrollbar {
66
height: auto;
77
}
88

9-
.fancybox-iosfix {
10-
height: 100%;
11-
left: 0;
12-
overflow: hidden;
13-
position: fixed;
14-
width: 100%;
15-
}
16-
179
.fancybox-is-hidden {
1810
left: -9999px;
1911
margin: 0;

src/js/core.js

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -517,18 +517,6 @@
517517
$container,
518518
buttonStr;
519519

520-
// iOS hack; https://bugs.webkit.org/show_bug.cgi?id=176896
521-
if (
522-
firstItem.type !== "image" &&
523-
/iPad|iPhone|iPod/.test(navigator.userAgent) &&
524-
!window.MSStream &&
525-
!$("body").hasClass("fancybox-iosfix")
526-
) {
527-
$("body")
528-
.addClass("fancybox-iosfix")
529-
.css("top", -$W.scrollTop());
530-
}
531-
532520
// Hide scrollbars
533521
// ===============
534522

@@ -2628,14 +2616,6 @@
26282616
$body.removeClass("fancybox-active compensate-for-scrollbar");
26292617

26302618
$("#fancybox-style-noscroll").remove();
2631-
2632-
if ($body.hasClass("fancybox-iosfix")) {
2633-
scrollTop = parseInt($body[0].style.top, 10);
2634-
2635-
$body.css("top", "").removeClass("fancybox-iosfix");
2636-
2637-
$W.scrollTop(-scrollTop);
2638-
}
26392619
}
26402620
},
26412621

src/js/media.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@
163163
return "&start=" + ((m ? parseInt(m, 10) * 60 : 0) + parseInt(s, 10));
164164
});
165165
} else if (providerName === "vimeo") {
166-
c = url.replace("&%23", "#");
166+
url = url.replace("&%23", "#");
167167
}
168168

169169
return false;

0 commit comments

Comments
 (0)