Change to switch plugin message customization depending on the presence of 35_change_load_order_locales.rb #30

Author: ishikawa999

README.md

@@ -12,7 +12,8 @@ $ cp plugins/redmine_message_customize/35_change_load_order_locales.rb config/in
 $ # redmine restart
 ```
 
-:warning: In order to customize messages of other plugins, it is necessary to copy redmine_message_customize/35_change_load_order_locales.rb into redmine/config/initializers.
+:warning: In order to customize messages of other plugins, it is necessary to copy redmine_message_customize/35_change_load_order_locales.rb into redmine/config/initializers.  
+If you don't have redmine/config/initializers/35_change_load_order_locales.rb, you can customize only messages other than plugins.
 
 ## Usage
 

lib/message_customize/locale.rb

@@ -1,6 +1,7 @@
 module MessageCustomize
   module Locale
     @available_messages = {}
+    CHANGE_LOARD_ORDER_LOCALES_FILE_PATH = 'config/initializers/35_change_load_order_locales.rb'
 
     class << self
       def available_locales
@@ -11,7 +12,16 @@ def reload!(*languages)
         available_languages = self.find_language(languages.flatten)
         paths = I18n.load_path.select {|path| available_languages.include?(File.basename(path, '.*').to_s)}
         I18n.backend.load_translations(paths)
-        available_languages.each{|lang| @available_messages[:"#{lang}"] = I18n.backend.send(:translations)[:"#{lang}"] || {}}
+        if customizable_plugin_messages?
+          available_languages.each{|lang| @available_messages[:"#{lang}"] = I18n.backend.send(:translations)[:"#{lang}"] || {}}
+        else
+          available_languages.each do |lang|
+            redmine_root_locale_path = Rails.root.join('config', 'locales', "#{lang}.yml")
+            if File.exist?(redmine_root_locale_path)
+              @available_messages[:"#{lang}"] = (I18n.backend.send(:load_yaml, redmine_root_locale_path)[lang] || {}).deep_symbolize_keys
+            end
+          end
+        end
       end
 
       def find_language(language=nil)
@@ -29,6 +39,10 @@ def available_messages(lang)
         self.reload!(lang) if @available_messages[lang].blank?
         @available_messages[lang] || {}
       end
+
+      def customizable_plugin_messages?
+        @customizable_plugin_messages ||= File.exist?(Rails.root.join(CHANGE_LOARD_ORDER_LOCALES_FILE_PATH))
+      end
     end
   end
 end

test/unit/lib/message_customize/locale_test.rb

@@ -30,17 +30,44 @@ def test_available_locales
     assert_equal locales.uniq.sort.map(&:to_sym), MessageCustomize::Locale.available_locales
   end
 
-  def test_available_messages_should_return_translations
+  def test_available_messages_if_customizable_plugin_messages
+    MessageCustomize::Locale.stubs(:customizable_plugin_messages?).returns(true)
+
     # Reset @available_messages
     MessageCustomize::Locale.instance_variable_set(:@available_messages, {})
 
     en_available_messages = MessageCustomize::Locale.available_messages('en')
     assert_equal 'am', en_available_messages[:time][:am]
+    assert_equal 'Message customize', en_available_messages[:label_custom_messages] # plugin messages
     assert_equal [:en], MessageCustomize::Locale.instance_variable_get(:@available_messages).keys
 
-    # Language 'ar' not loaded
-    ar_available_messages = MessageCustomize::Locale.available_messages('ar')
-    assert_equal "صباحا", ar_available_messages[:time][:am]
-    assert_equal [:en, :ar], MessageCustomize::Locale.instance_variable_get(:@available_messages).keys
+    # Language 'ja' not loaded
+    ja_available_messages = MessageCustomize::Locale.available_messages('ja')
+    assert_equal "午前", ja_available_messages[:time][:am]
+    assert_equal 'メッセージのカスタマイズ', ja_available_messages[:label_custom_messages] # plugin messages
+    assert_equal [:en, :ja], MessageCustomize::Locale.instance_variable_get(:@available_messages).keys
+  end
+
+  def test_available_messages_should_return_messages_without_plugin_messages_if_not_customizable_plugin_messages
+    MessageCustomize::Locale.stubs(:customizable_plugin_messages?).returns(false)
+
+    # Reset @available_messages
+    MessageCustomize::Locale.instance_variable_set(:@available_messages, {})
+
+    en_available_messages = MessageCustomize::Locale.available_messages('en')
+    assert_equal 'am', en_available_messages[:time][:am]
+    assert_nil en_available_messages[:label_custom_messages] # plugin messages
+    assert_equal [:en], MessageCustomize::Locale.instance_variable_get(:@available_messages).keys
+
+    # Language 'ja' not loaded
+    ja_available_messages = MessageCustomize::Locale.available_messages('ja')
+    assert_equal "午前", ja_available_messages[:time][:am]
+    assert_nil ja_available_messages[:label_custom_messages] # plugin messages
+    assert_equal [:en, :ja], MessageCustomize::Locale.instance_variable_get(:@available_messages).keys
+  end
+
+  def test_customizable_plugin_messages?
+    expect = File.exist?(Rails.root.join('config', 'initializers', MessageCustomize::Locale::CHANGE_LOARD_ORDER_LOCALES_FILE_PATH))
+    assert_equal expect, MessageCustomize::Locale.customizable_plugin_messages?
   end
 end