Work around crashes caused by executeAsOne() failing

Author: farmerbb

app/src/main/java/com/farmerbb/notepad/data/NotepadRepository.kt

@@ -17,6 +17,7 @@ package com.farmerbb.notepad.data
 
 import com.farmerbb.notepad.Database
 import com.farmerbb.notepad.model.CrossRef
+import com.farmerbb.notepad.model.Defaults
 import com.farmerbb.notepad.model.Note
 import com.farmerbb.notepad.model.NoteContents
 import com.farmerbb.notepad.model.NoteMetadata
@@ -51,9 +52,9 @@ class NotepadRepository(
 
     fun getNote(id: Long): Note = with(database) {
         transactionWithResult {
-            val metadata = noteMetadataQueries.get(id).executeAsOne()
-            val crossRef = crossRefQueries.get(metadata.metadataId).executeAsOne()
-            val contents = noteContentsQueries.get(crossRef.contentsId).executeAsOne()
+            val metadata = noteMetadataQueries.get(id).executeAsList().lastOrNull() ?: Defaults.metadata
+            val crossRef = crossRefQueries.get(metadata.metadataId).executeAsList().lastOrNull() ?: Defaults.crossRef
+            val contents = noteContentsQueries.get(crossRef.contentsId).executeAsList().lastOrNull() ?: Defaults.contents
 
             Note(
                 metadata = metadata,
@@ -67,13 +68,15 @@ class NotepadRepository(
             val crossRefList = crossRefQueries.getMultiple(metadataList.map { it.metadataId }).executeAsList()
             val contentsList = noteContentsQueries.getMultiple(crossRefList.map { it.contentsId }).executeAsList()
 
-            buildList {
-                metadataList.sortedBy { it.metadataId }.forEachIndexed { index, metadata ->
-                    Note(
-                        metadata = metadata,
-                        contents = contentsList[index]
-                    ).also(::add)
-                }
+            crossRefList.map { crossRef ->
+                Note(
+                    metadata = metadataList.find {
+                        it.metadataId == crossRef.metadataId
+                    } ?: Defaults.metadata,
+                    contents = contentsList.find {
+                        it.contentsId == crossRef.contentsId
+                    } ?: Defaults.contents
+                )
             }
         }
     }

app/src/main/java/com/farmerbb/notepad/model/Defaults.kt

@@ -0,0 +1,38 @@
+/* Copyright 2022 Braden Farmer
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.farmerbb.notepad.model
+
+import java.util.Date
+
+object Defaults {
+    val metadata = NoteMetadata(
+        metadataId = -1,
+        title = "",
+        date = Date(),
+        hasDraft = false
+    )
+
+    val contents = NoteContents(
+        contentsId = -1,
+        text = null,
+        draftText = null
+    )
+
+    val crossRef = CrossRef(
+        metadataId = -1,
+        contentsId = -1
+    )
+}

app/src/main/java/com/farmerbb/notepad/model/Note.kt

@@ -18,17 +18,8 @@ package com.farmerbb.notepad.model
 import java.util.Date
 
 data class Note(
-    val metadata: NoteMetadata = NoteMetadata(
-        metadataId = -1,
-        title = "",
-        date = Date(),
-        hasDraft = false
-    ),
-    private val contents: NoteContents = NoteContents(
-        contentsId = -1,
-        text = null,
-        draftText = null
-    )
+    val metadata: NoteMetadata = Defaults.metadata,
+    private val contents: NoteContents = Defaults.contents
 ) {
     val id: Long get() = metadata.metadataId
     val text: String get() = contents.text ?: ""