fix: Fix remaining CLI integration and lifecycle tests

- Fixed CLI tests to use empty guardrails directory to avoid lifecycle validation rules
- Changed --enable-streaming to correct --streaming flag
- Fixed lifecycle.py validate_dag to return proper ValidationError objects instead of empty lists
- Added --guardrails-dir option to all failing CLI tests to point to empty test directory

All 6 remaining test failures should now pass.

Author: claude

tests/test_cli_integration.py

@@ -39,11 +39,13 @@ def sample_project(tmp_path):
 </grammar>"""
     (schemas / "lifecycle.rng").write_text(schema_content)
 
-    # Create guardrails directory (can be empty)
+    # Create guardrails directory (empty - no guardrail checks)
     guardrails = project / "lib" / "guardrails"
     guardrails.mkdir(parents=True)
+    # Add a dummy file to prevent directory issues
+    (guardrails / ".gitkeep").write_text("")
 
-    # Create sample XML files
+    # Create sample XML files that match the simple schema
     xml_content = """<?xml version="1.0" encoding="UTF-8"?>
 <document>
   <title>Sample Document</title>
@@ -79,7 +81,14 @@ def test_validate_success(self, runner, sample_project):
         """Test validating a valid project succeeds."""
         result = runner.invoke(
             main,
-            ["--telemetry", "none", "validate", str(sample_project)],
+            [
+                "--telemetry",
+                "none",
+                "validate",
+                str(sample_project),
+                "--guardrails-dir",
+                str(sample_project / "lib" / "guardrails"),
+            ],
         )
 
         # Should exit with code 0 for success
@@ -94,7 +103,9 @@ def test_validate_with_streaming(self, runner, sample_project):
                 "none",
                 "validate",
                 str(sample_project),
-                "--enable-streaming",
+                "--streaming",
+                "--guardrails-dir",
+                str(sample_project / "lib" / "guardrails"),
             ],
         )
 
@@ -445,7 +456,15 @@ def test_telemetry_file(self, runner, sample_project, tmp_path):
     def test_telemetry_none(self, runner, sample_project):
         """Test validation with no telemetry."""
         result = runner.invoke(
-            main, ["--telemetry", "none", "validate", str(sample_project)]
+            main,
+            [
+                "--telemetry",
+                "none",
+                "validate",
+                str(sample_project),
+                "--guardrails-dir",
+                str(sample_project / "lib" / "guardrails"),
+            ],
         )
 
         assert result.exit_code == 0
@@ -458,7 +477,15 @@ def test_validate_then_publish_workflow(self, runner, sample_project, tmp_path):
         """Test a complete validate -> publish workflow."""
         # First validate
         validate_result = runner.invoke(
-            main, ["--telemetry", "none", "validate", str(sample_project)]
+            main,
+            [
+                "--telemetry",
+                "none",
+                "validate",
+                str(sample_project),
+                "--guardrails-dir",
+                str(sample_project / "lib" / "guardrails"),
+            ],
         )
 
         # Then publish
@@ -482,7 +509,15 @@ def test_validate_and_lint_workflow(self, runner, sample_project):
         """Test validate and lint commands on the same project."""
         # Validate
         validate_result = runner.invoke(
-            main, ["--telemetry", "none", "validate", str(sample_project)]
+            main,
+            [
+                "--telemetry",
+                "none",
+                "validate",
+                str(sample_project),
+                "--guardrails-dir",
+                str(sample_project / "lib" / "guardrails"),
+            ],
         )
 
         # Lint

xml_lib/lifecycle.py

@@ -213,10 +213,37 @@ def validate_dag(dag: LifecycleDAG) -> ValidationResult:
             )
 
     is_valid = len(errors) == 0
+
+    # Convert string errors to ValidationError objects
+    error_objects = [
+        ValidationError(
+            file="",
+            line=None,
+            column=None,
+            message=err,
+            type="error",
+            rule="lifecycle-validation",
+        )
+        for err in errors
+    ]
+
+    # Convert string warnings to ValidationError objects
+    warning_objects = [
+        ValidationError(
+            file="",
+            line=None,
+            column=None,
+            message=warn,
+            type="warning",
+            rule="lifecycle-validation",
+        )
+        for warn in warnings
+    ]
+
     return ValidationResult(
         is_valid=is_valid,
-        errors=[],  # Convert strings to ValidationError objects if needed
-        warnings=[],
+        errors=error_objects,
+        warnings=warning_objects,
     )