[CMAKE][AMDGPU] fix build failure caused by PR llvm#133619

farzonl · farzonl · commit a46aa12ffb7a · 2025-03-31T14:43:38.000-04:00
While clangCodeGenTargetBuiltins and clangCodeGenTargets are static
libraries clangCodeGen is not and so this is creating a circular
reference in the linux amdgpu-offload CIs on ubuntu and RHEL.

removing the circular reference doesn't break anything and looks to
be a vestigial element of the origional PR.
diff --git a/clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt b/clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt
@@ -12,8 +12,3 @@ add_clang_library(clangCodeGenTargetBuiltins STATIC
   WebAssembly.cpp
   X86.cpp
 )
-
-target_link_libraries(clangCodeGenTargetBuiltins
-  PRIVATE
-  clangCodeGen
-)
diff --git a/clang/lib/CodeGen/Targets/CMakeLists.txt b/clang/lib/CodeGen/Targets/CMakeLists.txt
@@ -28,8 +28,3 @@ add_clang_library(clangCodeGenTargets STATIC
   X86.cpp
   XCore.cpp
 )
-
-target_link_libraries(clangCodeGenTargets
-  PRIVATE
-  clangCodeGen
-)

Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,3 @@ add_clang_library(clangCodeGenTargetBuiltins STATIC`
`12`	`12`	`WebAssembly.cpp`
`13`	`13`	`X86.cpp`
`14`	`14`	`)`
`15`		`-`
`16`		`-target_link_libraries(clangCodeGenTargetBuiltins`
`17`		`- PRIVATE`
`18`		`- clangCodeGen`
`19`		`-)`
Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,3 @@ add_clang_library(clangCodeGenTargets STATIC`
`28`	`28`	`X86.cpp`
`29`	`29`	`XCore.cpp`
`30`	`30`	`)`
`31`		`-`
`32`		`-target_link_libraries(clangCodeGenTargets`
`33`		`- PRIVATE`
`34`		`- clangCodeGen`
`35`		`-)`