-
Notifications
You must be signed in to change notification settings - Fork 6
Description
While working on the fix for the NumPy 2.3 issue (PR #83), we discovered an additional problem in the fuselage and cabin sizing module.
In several places, we were using int() on float values. This results in truncation, not ceiling, which is problematic because it is not the intended behavior for sizing quantities (e.g. number of rows, seats, equipage members, etc.), where rounding up is usually required.
In the fix PR, we intentionally kept the truncation behavior to preserve legacy behavior and avoid introducing further breaking changes while addressing the NumPy issue.
The relevant implementation is here:
FAST-OAD_CS25/src/fastoad_cs25/models/geometry/geom_components/fuselage/compute_fuselage.py
Line 250 in f69fc2c
| npax_1 = np.trunc(1.05 * npax) |
However, from a modeling and sizing standpoint, this should likely use ceil instead of truncation.
This issue is to track that:
- current behavior is legacy-compatible but likely incorrect
- we should evaluate switching from truncation to
ceil - this change would be behavior-breaking and should be handled explicitly