Fix login log parameter error in task (#476)

Author: wu-clan

backend/app/admin/service/auth_service.py

@@ -13,6 +13,7 @@
 from backend.app.admin.service.login_log_service import login_log_service
 from backend.common.enums import LoginLogStatusType
 from backend.common.exception import errors
+from backend.common.log import log
 from backend.common.response.response_code import CustomErrorCode
 from backend.common.security.jwt import (
     create_access_token,
@@ -23,7 +24,7 @@
     password_verify,
 )
 from backend.core.conf import settings
-from backend.database.db_mysql import async_db_session
+from backend.database.db_mysql import async_db_session, uuid4_str
 from backend.database.db_redis import redis_client
 from backend.utils.timezone import timezone
 
@@ -52,44 +53,47 @@ async def login(
         self, *, request: Request, response: Response, obj: AuthLoginParam, background_tasks: BackgroundTasks
     ) -> GetLoginToken:
         async with async_db_session.begin() as db:
+            user = None
             try:
                 user = await self.user_verify(db, obj.username, obj.password)
-                user_id = user.id
-                user_uuid = user.uuid
-                username = user.username
                 captcha_code = await redis_client.get(f'{admin_settings.CAPTCHA_LOGIN_REDIS_PREFIX}:{request.state.ip}')
                 if not captcha_code:
                     raise errors.AuthorizationError(msg='验证码失效，请重新获取')
                 if captcha_code.lower() != obj.captcha.lower():
                     raise errors.CustomError(error=CustomErrorCode.CAPTCHA_ERROR)
+                user_id = user.id
                 a_token = await create_access_token(str(user_id), user.is_multi_login)
                 r_token = await create_refresh_token(str(user_id), user.is_multi_login)
             except errors.NotFoundError as e:
+                log.error('登陆错误: 用户名不存在')
                 raise errors.NotFoundError(msg=e.msg)
             except (errors.AuthorizationError, errors.CustomError) as e:
+                if not user:
+                    log.error('登陆错误: 用户密码有误')
                 task = BackgroundTask(
                     login_log_service.create,
                     **dict(
                         db=db,
                         request=request,
-                        user_uuid=user_uuid,
-                        username=username,
+                        user_uuid=user.uuid if user else uuid4_str(),
+                        username=obj.username,
                         login_time=timezone.now(),
                         status=LoginLogStatusType.fail.value,
                         msg=e.msg,
                     ),
                 )
                 raise errors.AuthorizationError(msg=e.msg, background=task)
             except Exception as e:
+                log.error(f'登陆错误: {e}')
                 raise e
             else:
                 background_tasks.add_task(
                     login_log_service.create,
                     **dict(
                         db=db,
                         request=request,
-                        user_uuid=user_uuid,
-                        username=username,
+                        user_uuid=user.uuid,
+                        username=obj.username,
                         login_time=timezone.now(),
                         status=LoginLogStatusType.success.value,
                         msg='登录成功',