Skip to content

Commit 68408d6

Browse files
committed
Changed how new users are added to a default organization
1 parent e58a07a commit 68408d6

File tree

3 files changed

+15
-16
lines changed

3 files changed

+15
-16
lines changed

backend/app/api/routes/private.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
from fastapi import APIRouter
44
from pydantic import BaseModel
55

6+
from app import crud
67
from app.api.deps import SessionDep
7-
from app.core.security import get_password_hash
88
from app.models import (
9-
User,
9+
UserCreate,
1010
UserPublic,
1111
)
1212

@@ -26,13 +26,11 @@ def create_user(user_in: PrivateUserCreate, session: SessionDep) -> Any:
2626
Create a new user.
2727
"""
2828

29-
user = User(
29+
user_create = UserCreate(
3030
email=user_in.email,
3131
full_name=user_in.full_name,
32-
hashed_password=get_password_hash(user_in.password),
32+
password=user_in.password,
3333
)
3434

35-
session.add(user)
36-
session.commit()
37-
35+
user = crud.create_user(session=session, user_create=user_create)
3836
return user

backend/app/api/routes/users.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -152,15 +152,6 @@ def register_user(session: SessionDep, user_in: UserRegister) -> Any:
152152
)
153153
user_create = UserCreate.model_validate(user_in)
154154
user = crud.create_user(session=session, user_create=user_create)
155-
156-
# Assign user to default organization
157-
default_org = crud.get_default_organization(session=session)
158-
if default_org:
159-
user.organization_id = default_org.id
160-
session.add(user)
161-
session.commit()
162-
session.refresh(user)
163-
164155
return user
165156

166157

backend/app/crud.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,16 @@ def create_user(*, session: Session, user_create: UserCreate) -> User:
3131
session.add(db_obj)
3232
session.commit()
3333
session.refresh(db_obj)
34+
35+
# Automatically assign user to default organization if not already assigned
36+
if not db_obj.organization_id:
37+
default_org = get_default_organization(session=session)
38+
if default_org:
39+
db_obj.organization_id = default_org.id
40+
session.add(db_obj)
41+
session.commit()
42+
session.refresh(db_obj)
43+
3444
return db_obj
3545

3646

0 commit comments

Comments
 (0)