feat: Add storage_path field to Attachment model for S3 file paths

Author: rbuels

backend/app/alembic/versions/2025_02_23_add_attachment_storage_path.py

@@ -0,0 +1,25 @@
+"""Add storage_path to Attachment model
+
+Revision ID: 2025_02_23_storage_path
+Revises: 2025_02_23_gin_idx
+Create Date: 2025-02-23 11:00:00.000000
+
+"""
+from alembic import op
+import sqlalchemy as sa
+
+# revision identifiers, used by Alembic.
+revision = '2025_02_23_storage_path'
+down_revision = '2025_02_23_gin_idx'
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    # Add storage_path column
+    op.add_column('attachment', sa.Column('storage_path', sa.String(length=1024), nullable=False))
+
+
+def downgrade() -> None:
+    # Remove storage_path column
+    op.drop_column('attachment', 'storage_path')

backend/app/tests/api/routes/test_attachments.py

@@ -25,6 +25,7 @@ def test_create_attachment(
     data = {
         "file_name": "test.pdf",
         "mime_type": "application/pdf",
+        "storage_path": "patients/attachments/test.pdf",
         "description": "Test attachment",
         "patient_id": str(patient.id)
     }
@@ -56,6 +57,7 @@ def test_read_attachment(
     attachment = Attachment(
         file_name="test.pdf",
         mime_type="application/pdf",
+        storage_path="patients/attachments/test.pdf",
         description="Test attachment",
         patient_id=patient.id
     )
@@ -89,11 +91,13 @@ def test_read_attachments(
     attachment1 = Attachment(
         file_name="test1.pdf",
         mime_type="application/pdf",
+        storage_path="patients/attachments/test1.pdf",
         patient_id=patient.id
     )
     attachment2 = Attachment(
         file_name="test2.pdf",
         mime_type="application/pdf",
+        storage_path="patients/attachments/test2.pdf",
         patient_id=patient.id
     )
     db.add(attachment1)
@@ -126,6 +130,7 @@ def test_update_attachment(
     attachment = Attachment(
         file_name="test.pdf",
         mime_type="application/pdf",
+        storage_path="patients/attachments/test.pdf",
         patient_id=patient.id
     )
     db.add(attachment)
@@ -160,6 +165,7 @@ def test_delete_attachment(
     attachment = Attachment(
         file_name="test.pdf",
         mime_type="application/pdf",
+        storage_path="patients/attachments/test.pdf",
         patient_id=patient.id
     )
     db.add(attachment)

backend/app/tests/api/routes/test_patients.py

@@ -210,11 +210,13 @@ def test_read_patients_attachment_filter(
     attachment1 = Attachment(
         file_name="test1.bam",
         mime_type="application/x-bam",
+        storage_path="patients/attachments/test1.bam",
         patient_id=patient1.id
     )
     attachment2 = Attachment(
         file_name="test.cram",
         mime_type="application/x-cram",
+        storage_path="patients/attachments/test.cram",
         patient_id=patient2.id
     )
     db.add(attachment1)