Skip to content

Commit a2dd74f

Browse files
committed
Separate permission error tests for existing and non-existing users.
1 parent 269da7c commit a2dd74f

File tree

1 file changed

+17
-9
lines changed

1 file changed

+17
-9
lines changed

backend/app/tests/api/routes/test_users.py

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -115,20 +115,28 @@ def test_get_existing_user_current_user(
115115
assert existing_user.email == api_user["email"]
116116

117117

118-
@pytest.mark.parametrize(
119-
"exists", (True, False), ids=lambda x: "Existing user" if x else "No user"
120-
)
121118
def test_get_existing_user_permissions_error(
122119
db: Session,
123120
client: TestClient,
124121
normal_user_token_headers: dict[str, str],
125-
exists: bool,
126122
) -> None:
127-
if exists:
128-
user = create_random_user(db)
129-
user_id = user.id
130-
else:
131-
user_id = uuid.uuid4()
123+
user = create_random_user(db)
124+
user_id = user.id
125+
126+
r = client.get(
127+
f"{settings.API_V1_STR}/users/{user_id}",
128+
headers=normal_user_token_headers,
129+
)
130+
assert r.status_code == 403
131+
assert r.json() == {"detail": "The user doesn't have enough privileges"}
132+
133+
134+
def test_get_non_existing_user_permissions_error(
135+
client: TestClient,
136+
normal_user_token_headers: dict[str, str],
137+
) -> None:
138+
user_id = uuid.uuid4()
139+
132140
r = client.get(
133141
f"{settings.API_V1_STR}/users/{user_id}",
134142
headers=normal_user_token_headers,

0 commit comments

Comments
 (0)