Skip to content

Commit e031948

Browse files
committed
Separate permission error tests for existing and non-existing users.
1 parent 1a0bb4a commit e031948

File tree

1 file changed

+17
-9
lines changed

1 file changed

+17
-9
lines changed

backend/app/tests/api/routes/test_users.py

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -114,20 +114,28 @@ def test_get_existing_user_current_user(client: TestClient, db: Session) -> None
114114
assert existing_user.email == api_user["email"]
115115

116116

117-
@pytest.mark.parametrize(
118-
"exists", (True, False), ids=lambda x: "Existing user" if x else "No user"
119-
)
120117
def test_get_existing_user_permissions_error(
121118
db: Session,
122119
client: TestClient,
123120
normal_user_token_headers: dict[str, str],
124-
exists: bool,
125121
) -> None:
126-
if exists:
127-
user = create_random_user(db)
128-
user_id = user.id
129-
else:
130-
user_id = uuid.uuid4()
122+
user = create_random_user(db)
123+
user_id = user.id
124+
125+
r = client.get(
126+
f"{settings.API_V1_STR}/users/{user_id}",
127+
headers=normal_user_token_headers,
128+
)
129+
assert r.status_code == 403
130+
assert r.json() == {"detail": "The user doesn't have enough privileges"}
131+
132+
133+
def test_get_non_existing_user_permissions_error(
134+
client: TestClient,
135+
normal_user_token_headers: dict[str, str],
136+
) -> None:
137+
user_id = uuid.uuid4()
138+
131139
r = client.get(
132140
f"{settings.API_V1_STR}/users/{user_id}",
133141
headers=normal_user_token_headers,

0 commit comments

Comments
 (0)