🐛 Fix reset behavior in EditItem mutation on success
#1533
Closed
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I reproduced the bug. |
|
Bug reproduction items-dashboard-bug.mp4 |
This comment was marked as duplicate.
This comment was marked as duplicate.
YuriiMotov
reviewed
Sep 3, 2025
Member
YuriiMotov
left a comment
YuriiMotov
left a comment
There was a problem hiding this comment.
Can confirm that issue is still relevant and this PR fixes it.
Suggestion: what if we just remove reset at all?
YuriiMotov
changed the title
EditItem mutation on success
Contributor
|
As this PR has been waiting for the original user for a while but seems to be inactive, it's now going to be closed. But if there's anyone interested, feel free to create a new PR. |
Contributor
|
This pull request has a merge conflict that needs to be resolved. |
github-actions
bot
added
the
conflicts
Member
|
Hi @samymsa thank you for the report! This was already handled, now closing the dialog + query invalidation ensures fresh data when reopening (this version version will be released soon 🚀) Screencast.from.2025-12-08.13-36-47.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the ItemUpdateForm (in EditItem) would reset to its default values upon successful mutation. As a result, reopening the update form would display outdated predefined values. The fix ensures the form state is correctly updated with the latest item data after a successful update.