Fix This ForeignKey already has a parent for test_base_model_fk

Author: YuriiMotov

sqlmodel/main.py

@@ -3,6 +3,7 @@
 import ipaddress
 import uuid
 import weakref
+from copy import copy
 from datetime import date, datetime, time, timedelta
 from decimal import Decimal
 from enum import Enum
@@ -750,7 +751,7 @@ def get_column_from_field(field: Any) -> Column:  # type: ignore
             args.append(ForeignKey(foreign_key, ondelete=ondelete))
         else:
             assert isinstance(foreign_key, ForeignKey)
-            args.append(foreign_key.copy())
+            args.append(copy(foreign_key))
     kwargs = {
         "primary_key": primary_key,
         "nullable": nullable,
@@ -766,7 +767,11 @@ def get_column_from_field(field: Any) -> Column:  # type: ignore
         kwargs["default"] = sa_default
     sa_column_args = getattr(field_info, "sa_column_args", Undefined)
     if sa_column_args is not Undefined:
-        args.extend(list(cast(Sequence[Any], sa_column_args)))
+        for arg_v in sa_column_args:
+            if isinstance(arg_v, ForeignKey):
+                args.append(copy(arg_v))
+            else:
+                args.append(arg_v)
     sa_column_kwargs = getattr(field_info, "sa_column_kwargs", Undefined)
     if sa_column_kwargs is not Undefined:
         kwargs.update(cast(Dict[Any, Any], sa_column_kwargs))

tests/test_field_sa_fk_args_kwargs.py

@@ -1,12 +1,8 @@
-import contextlib
 import re
 from typing import Optional
 
-import pytest
-import sqlalchemy.exc
 from sqlalchemy import ForeignKey, create_engine
 from sqlmodel import Field, SQLModel
-from sqlmodel._compat import IS_PYDANTIC_V2
 
 
 def test_base_model_fk(clear_sqlmodel, caplog) -> None:
@@ -21,18 +17,8 @@ class Base(SQLModel):
     class Asset(Base, table=True):
         id: Optional[int] = Field(default=None, primary_key=True)
 
-    # Fails in Pydantic v2, but not v1
-    with (
-        pytest.raises(sqlalchemy.exc.InvalidRequestError)
-        if IS_PYDANTIC_V2
-        else contextlib.nullcontext()
-    ) as e:
-
-        class Document(Base, table=True):
-            id: Optional[int] = Field(default=None, primary_key=True)
-
-    if e:
-        assert "This ForeignKey already has a parent" in str(e.errisinstance)
+    class Document(Base, table=True):
+        id: Optional[int] = Field(default=None, primary_key=True)
 
     engine = create_engine("sqlite://", echo=True)
     SQLModel.metadata.create_all(engine)